From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Gareth Williams <gareth.williams.jx@renesas.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Vinod Koul <vkoul@kernel.org>,
linux-renesas-soc@vger.kernel.org, dmaengine@vger.kernel.org,
Milan Stevanovic <milan.stevanovic@se.com>,
Jimmy Lalande <jimmy.lalande@se.com>,
Pascal Eberhard <pascal.eberhard@se.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Clement Leger <clement.leger@bootlin.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v9 5/9] dmaengine: dw: dmamux: Introduce RZN1 DMA router support
Date: Tue, 12 Apr 2022 17:17:05 +0200 [thread overview]
Message-ID: <20220412171705.0dd51846@xps13> (raw)
In-Reply-To: <YlVdsTVpWrx+XaUH@smile.fi.intel.com>
Hi Andy,
andriy.shevchenko@linux.intel.com wrote on Tue, 12 Apr 2022 14:08:33
+0300:
> On Tue, Apr 12, 2022 at 02:06:31PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 12, 2022 at 12:21:34PM +0200, Miquel Raynal wrote:
>
> ...
>
> > > + clear_bit(BIT(map->req_idx), dmamux->used_chans);
>
> On top of the previously asked, are you sure the use of BIT() is correct here?
Looks like I have been tricked by the doc...
* DOC: bitmap bitops
* set_bit(bit, addr) *addr |= bit
* clear_bit(bit, addr) *addr &= ~bit
next prev parent reply other threads:[~2022-04-12 15:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 10:21 [PATCH v9 0/9] RZN1 DMA support Miquel Raynal
2022-04-12 10:21 ` [PATCH v9 1/9] dt-bindings: dmaengine: Introduce RZN1 dmamux bindings Miquel Raynal
2022-04-12 12:13 ` Vinod Koul
2022-04-12 10:21 ` [PATCH v9 2/9] dt-bindings: clock: r9a06g032-sysctrl: Reference the DMAMUX subnode Miquel Raynal
2022-04-12 10:21 ` [PATCH v9 3/9] dt-bindings: dmaengine: Introduce RZN1 DMA compatible Miquel Raynal
2022-04-12 12:14 ` Vinod Koul
2022-04-12 10:21 ` [PATCH v9 4/9] soc: renesas: rzn1-sysc: Export function to set dmamux Miquel Raynal
2022-04-12 10:21 ` [PATCH v9 5/9] dmaengine: dw: dmamux: Introduce RZN1 DMA router support Miquel Raynal
2022-04-12 11:06 ` Andy Shevchenko
2022-04-12 11:08 ` Andy Shevchenko
2022-04-12 15:17 ` Miquel Raynal [this message]
2022-04-12 15:39 ` Miquel Raynal
2022-04-12 10:21 ` [PATCH v9 6/9] clk: renesas: r9a06g032: Probe possible children Miquel Raynal
2022-04-12 10:21 ` [PATCH v9 7/9] dmaengine: dw: Add RZN1 compatible Miquel Raynal
2022-04-12 12:15 ` Vinod Koul
2022-04-12 10:21 ` [PATCH v9 8/9] ARM: dts: r9a06g032: Add the two DMA nodes Miquel Raynal
2022-04-12 10:21 ` [PATCH v9 9/9] ARM: dts: r9a06g032: Describe the DMA router Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412171705.0dd51846@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gareth.williams.jx@renesas.com \
--cc=geert@linux-m68k.org \
--cc=herve.codina@bootlin.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jimmy.lalande@se.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=mturquette@baylibre.com \
--cc=pascal.eberhard@se.com \
--cc=phil.edworthy@renesas.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).