From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E66C433F5 for ; Wed, 13 Apr 2022 14:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236023AbiDMOJC (ORCPT ); Wed, 13 Apr 2022 10:09:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236087AbiDMOI6 (ORCPT ); Wed, 13 Apr 2022 10:08:58 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8215FF2D for ; Wed, 13 Apr 2022 07:06:36 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id ks6so4229261ejb.1 for ; Wed, 13 Apr 2022 07:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1K/RPiyzv/rwySVDedqK5ecMTT01CdoSCB+tdz/b9HI=; b=bYPycsGq1Dy1M+2s+8o3DuKr3Bt4dqO5oF3Q7J8B4f7KxwxbLRYfMcws+fXB8veOYp gsCxuu8nkIQXuF9wTkli8wllqevhX7i6IMDRjr4Xoqts7Xg4p3emJNgGeV20sO/FJuDn YaYFdNPeg/d6GeUVOTslta7snioXVLoz3cajM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1K/RPiyzv/rwySVDedqK5ecMTT01CdoSCB+tdz/b9HI=; b=kglI9rc5l9reluA77ps0/+e91Pmf3OMt4cOsOFnJQ8rhEIkkc61Lp01hNH9r271sOM f3NP5tTwrexrTGwx6Fe9jZEoSVPl3VK4lMnfP9MYVmPuyQuEcZAWD4+mqnEEm1WEmhtR tbarCw+wWKnROQxllWDn0sZhujGFJW22s/vIdWuRO3kz0WEjgp6hE4UFwoLmg418+Jki F+BHzLe1DQsl3Lvacxrg3O53LE+0nu+31cqRLA/JMO3vLq9B2ltJYjJe1Yl+Url0ZkZn HgUAqv5rHaigSQj9e/ZWMKOG9Zcsbg1CNU+l5CzP3JCdq46yJpHB2gr0BWq2CaXMtRsM kCyQ== X-Gm-Message-State: AOAM532dzzL8NFP2GRBRpfZL8qvL5z0C2ozXdwCosF/khPwxvOtfsWjJ LorIH2rCLY+lba16s+bIsJ78MA== X-Google-Smtp-Source: ABdhPJyDLkxYfQJbdeaHEzd/tsYxg3C6HOqAziPxNHd+yNsF3Zci7M5aRWaWBaPd2d5DkowAVVjbXA== X-Received: by 2002:a17:906:c282:b0:6ce:369d:3d5 with SMTP id r2-20020a170906c28200b006ce369d03d5mr38884028ejz.425.1649858794786; Wed, 13 Apr 2022 07:06:34 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (host-95-245-147-71.retail.telecomitalia.it. [95.245.147.71]) by smtp.gmail.com with ESMTPSA id o5-20020a50c905000000b0041d828d0c58sm1197762edh.53.2022.04.13.07.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 07:06:34 -0700 (PDT) Date: Wed, 13 Apr 2022 16:06:32 +0200 From: Tommaso Merciai To: Krzysztof Kozlowski Cc: linux-amarula@amarulasolutions.com, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Joakim Zhang , Li Jun , Tim Harvey , Richard Zhu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mm-evk: add pwm1/backlight support Message-ID: <20220413140632.GC4713@tom-ThinkPad-T14s-Gen-2i> References: <20220413125636.28650-1-tommaso.merciai@amarulasolutions.com> <8283132d-c271-d1b8-cb28-8f95305b11ec@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8283132d-c271-d1b8-cb28-8f95305b11ec@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Apr 13, 2022 at 03:45:44PM +0200, Krzysztof Kozlowski wrote: > On 13/04/2022 14:56, Tommaso Merciai wrote: > > Add pwm1/backlight support nodes for imx8mm_evk board. > > Align with u-boot dts > > > > Thank you for your patch. There is something to discuss/improve. > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > index 6d67df7692f1..4c18f8fcd377 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > @@ -59,6 +59,15 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > > enable-active-high; > > }; > > > > + backlight: backlight { > > + status = "okay"; > > All nodes have status=okay by default, so no need for this. > > > + compatible = "pwm-backlight"; > > + pwms = <&pwm1 0 5000000>; > > + brightness-levels = <0 255>; > > + num-interpolated-steps = <255>; > > + default-brightness-level = <250>; > > + }; > > + > > ir-receiver { > > compatible = "gpio-ir-receiver"; > > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > > @@ -395,6 +404,12 @@ &wdog1 { > > status = "okay"; > > }; > > > > +&pwm1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_backlight>; > > + status = "okay"; > > This is needed if the node was disabled in DTSI (I did not check it). > > > Best regards, > Krzysztof Hi Krzysztof, Thanks for review, I'll update in v3. Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com