* [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor'
@ 2022-04-13 13:47 Rob Herring
2022-04-13 14:06 ` Krzysztof Kozlowski
2022-04-13 14:07 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-04-13 13:47 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski
Cc: linux-hwmon, devicetree, linux-kernel
'ti,n-factor' is read as a 32-bit signed value, so the type and constraints
are wrong. The same property is also defined for ti,tmp464 and is correct.
The constraints should also not be under 'items' as this property is not an
array.
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
index 36f649938fb7..a6f1fa75a67c 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
@@ -58,10 +58,9 @@ patternProperties:
description: |
The value (two's complement) to be programmed in the channel specific N correction register.
For remote channels only.
- $ref: /schemas/types.yaml#/definitions/uint32
- items:
- minimum: 0
- maximum: 255
+ $ref: /schemas/types.yaml#/definitions/int32
+ minimum: -128
+ maximum: 127
required:
- reg
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor'
2022-04-13 13:47 [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor' Rob Herring
@ 2022-04-13 14:06 ` Krzysztof Kozlowski
2022-04-13 14:07 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-13 14:06 UTC (permalink / raw)
To: Rob Herring, Jean Delvare, Guenter Roeck, Krzysztof Kozlowski
Cc: linux-hwmon, devicetree, linux-kernel
On 13/04/2022 15:47, Rob Herring wrote:
> 'ti,n-factor' is read as a 32-bit signed value, so the type and constraints
> are wrong. The same property is also defined for ti,tmp464 and is correct.
>
> The constraints should also not be under 'items' as this property is not an
> array.
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor'
2022-04-13 13:47 [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor' Rob Herring
2022-04-13 14:06 ` Krzysztof Kozlowski
@ 2022-04-13 14:07 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-04-13 14:07 UTC (permalink / raw)
To: Rob Herring
Cc: Jean Delvare, Krzysztof Kozlowski, linux-hwmon, devicetree,
linux-kernel
On Wed, Apr 13, 2022 at 08:47:29AM -0500, Rob Herring wrote:
> 'ti,n-factor' is read as a 32-bit signed value, so the type and constraints
> are wrong. The same property is also defined for ti,tmp464 and is correct.
>
> The constraints should also not be under 'items' as this property is not an
> array.
>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: linux-hwmon@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied.
Thanks,
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
> index 36f649938fb7..a6f1fa75a67c 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp421.yaml
> @@ -58,10 +58,9 @@ patternProperties:
> description: |
> The value (two's complement) to be programmed in the channel specific N correction register.
> For remote channels only.
> - $ref: /schemas/types.yaml#/definitions/uint32
> - items:
> - minimum: 0
> - maximum: 255
> + $ref: /schemas/types.yaml#/definitions/int32
> + minimum: -128
> + maximum: 127
>
> required:
> - reg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-13 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-13 13:47 [PATCH] dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor' Rob Herring
2022-04-13 14:06 ` Krzysztof Kozlowski
2022-04-13 14:07 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).