From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2274C433F5 for ; Wed, 13 Apr 2022 14:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232990AbiDMOwm (ORCPT ); Wed, 13 Apr 2022 10:52:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234561AbiDMOwV (ORCPT ); Wed, 13 Apr 2022 10:52:21 -0400 X-Greylist: delayed 104938 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 13 Apr 2022 07:49:58 PDT Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94CDA167E9 for ; Wed, 13 Apr 2022 07:49:58 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 716D240009; Wed, 13 Apr 2022 14:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1649861397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l7gqjjhj0XbhASsT9yx1167D/NkqUVY3vj/OxIB/ROU=; b=nhhCNspC0kHQKc6yGBP+mIyCoLG+cWyi075dvuNNmJpNn0lfozq6KB5nskGwe5Gi5QlQ+n Unaeh9evR+5dHfSfUUrakEV1DZSrmcPDliXM4RF0pysUogHcq55xIPO+TD+48mJoii0RvE vSb6C6jC3Di1zsaw31MZPHh0or52spHX8ICd0XYqd1CAZc4qphhWIrryj4udfFeFtEuSTv KRq8EgccyQtQyViaPjWMA8UBDAj6zHrtdj12XHJDLXR35VU2kDHxp1lSc1i5iq/fuu5lr5 nLCU7DbxLoKBhNe+YlrLIDC06rxVDQDaqT6mqcONpqpFWY2J+7wiI5k9k9DzEg== Date: Wed, 13 Apr 2022 16:49:54 +0200 From: Herve Codina To: Rob Herring Cc: Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRz?= =?UTF-8?B?a2k=?= , linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Clement Leger , Miquel Raynal Subject: Re: [PATCH 1/6] PCI: rcar-gen2: Add support for clocks Message-ID: <20220413164954.32365292@bootlin.com> In-Reply-To: References: <20220412094029.287562-1-herve.codina@bootlin.com> <20220412094029.287562-2-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Tue, 12 Apr 2022 10:50:10 -0500 Rob Herring wrote: > On Tue, Apr 12, 2022 at 11:40:24AM +0200, Herve Codina wrote: > > The PCI rcar-gen2 does not call any clk_prepare_enable(). > > This lead to an access failure when the driver tries to access > > the IP (at least on a RZ/N1D platform). > >=20 > > Prepare and enable clocks using the bulk version of > > clk_prepare_enable() in order to prepare and enable all clocks > > attached to this device. =20 >=20 > The binding says there is only a single clock, so it needs an update if=20 > there are multiple clocks. (And ideally converted to DT schema format.) Indeed, I will convert to DT schema format and update the clocks property description. Regards, Herv=C3=A9