From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: sakari.ailus@iki.fi, paul.j.murphy@intel.com,
daniele.alessandrelli@intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Cc: robert.foss@linaro.org, hfink@snap.com, jgrahsl@snap.com,
dmitry.baryshkov@linaro.org, vladimir.zapolskiy@linaro.org,
bryan.odonoghue@linaro.org
Subject: [PATCH v3 0/2] media: i2c: imx412: Add regulator control to imx412
Date: Thu, 14 Apr 2022 13:45:03 +0100 [thread overview]
Message-ID: <20220414124505.1329295-1-bryan.odonoghue@linaro.org> (raw)
V3:
- int num_supplies -> unsigned int num_supplied - Saraki
- Move imx412->num_supplies to same line as devm_regulator_bulk_get - Saraki
- Return ret on regulator_bulk_enable() - Saraki
- Remember to regulator_bulk_disable() on !clk_prepare_enable() - Saraki
V2:
- Drops redundant verbage "Definition of the" from each of the newly defined
regulators - Krzysztof Kozlowski
- Adds Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
- "description: thing described" to the same line in new additions
following the established way of doing it in this file - bod
V1:
The imx412 has three regulators which depending on platform may need to be
individually enabled.
- dovdd
- avdd
- dvdd
Existing code for an Intel platform doesn't appear to need to enable these
rails directly. On my reference hardware, a Qualcomm Thundercomm RB5 some
of these rails do need to be enabled individually.
Add in the above named rails as optional in the YAML in the first patch
along with code to switch them on in the second patch.
Existing imx412 users should get dummy regulators populated which the
regulator_bulk_enable()/regulator_bulk_disable() code can safely ignore.
Bryan O'Donoghue (2):
media: dt-bindings: imx412: Add regulator descriptions
media: i2c: imx412: Add bulk regulator support
.../bindings/media/i2c/sony,imx412.yaml | 9 ++++++
drivers/media/i2c/imx412.c | 31 +++++++++++++++++++
2 files changed, 40 insertions(+)
--
2.35.1
next reply other threads:[~2022-04-14 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 12:45 Bryan O'Donoghue [this message]
2022-04-14 12:45 ` [PATCH v3 1/2] media: dt-bindings: imx412: Add regulator descriptions Bryan O'Donoghue
2022-04-14 12:45 ` [PATCH v3 2/2] media: i2c: imx412: Add bulk regulator support Bryan O'Donoghue
2022-04-14 13:00 ` Sakari Ailus
2022-04-14 13:44 ` Bryan O'Donoghue
2022-04-14 13:56 ` Sakari Ailus
2022-04-14 14:04 ` Bryan O'Donoghue
2022-04-14 14:16 ` Sakari Ailus
2022-04-14 14:50 ` Bryan O'Donoghue
2022-04-14 21:58 ` Sakari Ailus
2022-04-14 22:32 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414124505.1329295-1-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=hfink@snap.com \
--cc=jgrahsl@snap.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robert.foss@linaro.org \
--cc=sakari.ailus@iki.fi \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).