Re: [PATCH net-next 02/12] net: dsa: add Renesas RZ/N1 switch tag driver

Russell King (Oracle)
2022-04-14T16:53:07Z

On Thu, Apr 14, 2022 at 06:18:15PM +0200, Clément Léger wrote:
> Le Thu, 14 Apr 2022 18:11:46 +0300,
> Vladimir Oltean <olteanv@gmail.com> a écrit :
>
> > On Thu, Apr 14, 2022 at 04:35:46PM +0200, Clément Léger wrote:
> > > > Please keep variable declarations sorted in decreasing order of line
> > > > length (applies throughout the patch series, I won't repeat this comment).
> > >
> > > Acked, both PCS and DSA driver are ok with that rule. Missed that one
> > > though.
> >
> > Are you sure? Because a5psw_port_stp_state_set() says otherwise.
>
> Weeeeell, ok let's say I missed these two. Would be useful to have such
> checks in checkpatch.pl.

Note that it's a local networking coding-style issue, rather than being
kernel-wide.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!