Re: [PATCH net-next 06/12] net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver

Russell King (Oracle)
2022-04-15T08:53:00Z

On Fri, Apr 15, 2022 at 10:40:29AM +0200, Clément Léger wrote:
> Le Thu, 14 Apr 2022 14:02:10 +0100,
> "Russell King (Oracle)" <linux@armlinux.org.uk> a écrit :
>
> > On Thu, Apr 14, 2022 at 02:22:44PM +0200, Clément Léger wrote:
> > > Add Renesas RZ/N1 advanced 5 port switch driver. This switch handles 5
> > > ports including 1 CPU management port. A MDIO bus is also exposed by
> > > this switch and allows to communicate with PHYs connected to the ports.
> > > Each switch port (except for the CPU management ports) are connected to
> > > the MII converter.
> > >
> > > This driver include basic bridging support, more support will be added
> > > later (vlan, etc).
> >
> > This patch looks to me like it needs to be updated...
>
> Hi Russell,
>
> When you say so, do you expect the VLAN support to be included ?

I was referring to the use of .phylink_validate rather than
.phylink_get_caps - all but one DSA driver have been recently updated
to use the latter, and the former should now only be used in
exceptional circumstances.

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!