* [PATCH 1/7] dt-bindings: input: mtk-pmic-keys: add MT6359 binding definition [not found] <20220415153629.1817202-1-fparent@baylibre.com> @ 2022-04-15 15:36 ` Fabien Parent 2022-04-15 15:36 ` [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support Fabien Parent 1 sibling, 0 replies; 3+ messages in thread From: Fabien Parent @ 2022-04-15 15:36 UTC (permalink / raw) To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: Fabien Parent, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Add binding definition for the support of the MT6359 keyboard driver. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- Documentation/devicetree/bindings/input/mtk-pmic-keys.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt index 9d00f2a8e13a..afe9062a4dc7 100644 --- a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt @@ -13,6 +13,7 @@ Required properties: - "mediatek,mt6397-keys" - "mediatek,mt6323-keys" - "mediatek,mt6358-keys" + - "mediatek,mt6359-keys" - linux,keycodes: See Documentation/devicetree/bindings/input/input.yaml Optional Properties: -- 2.35.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support [not found] <20220415153629.1817202-1-fparent@baylibre.com> 2022-04-15 15:36 ` [PATCH 1/7] dt-bindings: input: mtk-pmic-keys: add MT6359 binding definition Fabien Parent @ 2022-04-15 15:36 ` Fabien Parent 2022-04-21 10:33 ` AngeloGioacchino Del Regno 1 sibling, 1 reply; 3+ messages in thread From: Fabien Parent @ 2022-04-15 15:36 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: Fabien Parent, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Add node for the MT6359 PMIC keyboard in mt6359.dtsi. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- Dependency on: https://patchwork.kernel.org/project/linux-mediatek/patch/1622011927-359-9-git-send-email-hsin-hsiung.wang@mediatek.com/ arch/arm64/boot/dts/mediatek/mt6359.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi index 18c0d5325c22..dcafe1ff23ae 100644 --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi @@ -3,6 +3,8 @@ * Copyright (c) 2021 MediaTek Inc. */ +#include <dt-bindings/input/input.h> + &pwrap { pmic: pmic { compatible = "mediatek,mt6359"; @@ -294,5 +296,18 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub { mt6359rtc: mt6359rtc { compatible = "mediatek,mt6358-rtc"; }; + + mt6359keys: keyboard { + compatible = "mediatek,mt6359-keys"; + + key-0 { + linux,keycodes = <KEY_POWER>; + wakeup-source; + }; + + key-1 { + linux,keycodes = <KEY_HOME>; + }; + }; }; }; -- 2.35.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support 2022-04-15 15:36 ` [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support Fabien Parent @ 2022-04-21 10:33 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 3+ messages in thread From: AngeloGioacchino Del Regno @ 2022-04-21 10:33 UTC (permalink / raw) To: Fabien Parent, Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Il 15/04/22 17:36, Fabien Parent ha scritto: > Add node for the MT6359 PMIC keyboard in mt6359.dtsi. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> Hello Fabien, I agree that all MT6359 PMICs do support pmic-keys, but not all devices using this PMIC have physical keys connected to that. Besides, even if all of them did, it wouldn't be guaranteed that key-0 would be always KEY_POWER, as much as it wouldn't be guaranteed that key-1 would be always KEY_HOME. In my opinion, it *is* correct to add mediatek,mt6359-keys to the PMIC dtsi, but you should do that without declaring any key, hence it's enough to do: mt6359_keys: mtk-pmic-keys { compatible = "mediatek,mt6359-keys"; }; ... then, any machine that *actually does* have these keys connected and manageable in Linux should declare its own keys in its own dts/dtsi. Of course, this means that you'll have to remove your input.h inclusion as well. Regards, Angelo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-21 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220415153629.1817202-1-fparent@baylibre.com>
2022-04-15 15:36 ` [PATCH 1/7] dt-bindings: input: mtk-pmic-keys: add MT6359 binding definition Fabien Parent
2022-04-15 15:36 ` [PATCH 7/7] arm64: dts: mediatek: mt6359: add node for PMIC keys support Fabien Parent
2022-04-21 10:33 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).