Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible

Nishanth Menon
2022-04-15T18:54:53Z

On 16:31-20220407, Krzysztof Kozlowski wrote:
> Vendor prefix in compatible should be lower-case.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 8f49883a675e..9e507293a8d7 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -140,7 +140,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index f968af0bfad3..1a1a49c19a19 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -164,7 +164,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index 32619b3c5804..06d55b89170d 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -113,7 +113,7 @@ &spi0 {
> nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "Micron,n25q128a11";
> + compatible = "micron,n25q128a11";
> spi-max-frequency = <54000000>;
> m25p,fast-read;
> reg = <0>;

I have no idea how this works. There is no documentation for the
compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor";

$ git grep micron,n25q128a11 .
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11";
arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11";
arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11";
arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor";
arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D