From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FA9C433EF for ; Wed, 20 Apr 2022 04:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347192AbiDTEh1 (ORCPT ); Wed, 20 Apr 2022 00:37:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236411AbiDTEh1 (ORCPT ); Wed, 20 Apr 2022 00:37:27 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 530F810CD; Tue, 19 Apr 2022 21:34:42 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4E88F67373; Wed, 20 Apr 2022 06:34:38 +0200 (CEST) Date: Wed, 20 Apr 2022 06:34:37 +0200 From: "hch@lst.de" To: Arnd Bergmann Cc: Sven Peter , "hch@lst.de" , Keith Busch , "axboe@fb.com" , "sagi@grimberg.me" , Hector Martin , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Marc Zyngier , DTML , Linux ARM , Linux Kernel Mailing List , linux-nvme@lists.infradead.org, linux-spdx@vger.kernel.org Subject: Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver Message-ID: <20220420043437.GA1123@lst.de> References: <20220415142055.30873-1-sven@svenpeter.dev> <20220415142055.30873-7-sven@svenpeter.dev> <20220419053157.GA31530@lst.de> <866f79b1-6c02-4248-ac98-594829fed204@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Apr 19, 2022 at 11:52:15AM +0200, Arnd Bergmann wrote: > > I just checked again and 64-bit accesses seem to work fine. > > I'll remove the lo_hi_* calls and this include. > > If you remove the #include, it is no longer possible to compile-test > this on all 32-bit architectures, though that is probably fine as long > as the Kconfig file has the right dependencies, like > > depends on ARCH_APPLE || (COMPILE_TEST && 64BIT) > > I'd prefer to keep the #include here, but I don't mind the dependency > if Christoph prefers it that way. So thre's really two steps here: 1) stop uing lo_hi_readq diretly which forces 32-bit access even on 64-bit platforms 2) stop using the io-64-nonatomic headers entirely I definitively want 1) done if the hardware does not require it. Trying to cater to 32-bit build tests on hardware that has no chance of ever being used there by including the header seems a bit silly, but if it makes folks happy I can live with it. > > Arnd ---end quoted text---