From: Fabio Baltieri <fabiobaltieri@chromium.org>
To: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
chrome-platform@lists.linux.dev, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Fabio Baltieri" <fabiobaltieri@chromium.org>
Subject: [PATCH v5 0/4] Add channel type support to pwm-cros-ec
Date: Wed, 20 Apr 2022 14:15:52 +0000 [thread overview]
Message-ID: <20220420141556.681212-1-fabiobaltieri@chromium.org> (raw)
Hi,
The ChromiumOS EC PWM host command protocol supports specifying the
requested PWM by type rather than channel. [1]
This series adds support for specifying PWM by type rather than channel
number in the pwm-cros-ec driver, which abstracts the node definitions
from the actual hardware configuration from the kernel perspective,
aligns the API with the one used by the bootloader, and allows removing
some dtsi overrides.
Tested on a sc7180-trogdor board, build tested on x86.
Changes from v4:
(https://patchwork.kernel.org/project/chrome-platform/list/?series=632212)
- fixed wrong indentation in the devietree file on patch 3
- added review and ack tags from the previous run
Changes from v3:
(https://patchwork.kernel.org/project/chrome-platform/list/?series=631131)
- actually reworded patch 2 commit description
- reworked patch 2 to use of_device_is_compatible() instead of compatible .data
Changes from v2:
(https://patchwork.kernel.org/project/chrome-platform/list/?series=627837)
- reworded patch 2 commit description
- reworked the driver and dt documentation to use a new compatible rather than
boolean property
- dropped the comment about build test only, tested on actual hardware
(trogdor), build test on x86 (with CONFIG_OF=n).
Changes from v1:
(https://patchwork.kernel.org/project/chrome-platform/list/?series=625182)
- fixed the dt include file license
- fixed the property name (s/_/-/)
- rebased on current linus tree (few dts files changed from a soc tree
pull, so patch 4 needs a recent base to apply correctly)
[1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/ec/common/pwm.c;l=24
[2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/depthcharge/src/drivers/ec/cros/ec.c;l=1271-1273
Fabio Baltieri (4):
dt-bindings: add mfd/cros_ec definitions
pwm: pwm-cros-ec: add channel type support
dt-bindings: update google,cros-ec-pwm documentation
arm64: dts: address cros-ec-pwm channels by type
.../bindings/pwm/google,cros-ec-pwm.yaml | 9 +-
.../mt8183-kukui-jacuzzi-fennel-sku1.dts | 4 +-
.../dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 4 +-
.../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
.../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 4 -
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 +-
.../qcom/sc7280-herobrine-herobrine-r0.dts | 7 +-
.../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 7 +-
.../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 4 +-
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 7 +-
.../boot/dts/rockchip/rk3399-gru-bob.dts | 4 -
.../dts/rockchip/rk3399-gru-chromebook.dtsi | 5 +-
.../boot/dts/rockchip/rk3399-gru-kevin.dts | 4 -
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 +
drivers/pwm/pwm-cros-ec.c | 82 +++++++++++++++----
include/dt-bindings/mfd/cros_ec.h | 18 ++++
16 files changed, 121 insertions(+), 49 deletions(-)
create mode 100644 include/dt-bindings/mfd/cros_ec.h
--
2.36.0.rc0.470.gd361397f0d-goog
next reply other threads:[~2022-04-20 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:15 Fabio Baltieri [this message]
2022-04-20 14:15 ` [PATCH v5 1/4] dt-bindings: add mfd/cros_ec definitions Fabio Baltieri
2022-04-20 14:15 ` [PATCH v5 2/4] pwm: pwm-cros-ec: add channel type support Fabio Baltieri
2022-04-20 17:55 ` Prashant Malani
2022-04-21 8:34 ` Fabio Baltieri
2022-04-21 8:52 ` Prashant Malani
2022-04-21 9:42 ` Fabio Baltieri
2022-04-20 14:15 ` [PATCH v5 3/4] dt-bindings: update google,cros-ec-pwm documentation Fabio Baltieri
2022-04-25 21:58 ` Rob Herring
2022-04-26 14:02 ` Fabio Baltieri
2022-04-20 14:15 ` [PATCH v5 4/4] arm64: dts: address cros-ec-pwm channels by type Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420141556.681212-1-fabiobaltieri@chromium.org \
--to=fabiobaltieri@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).