devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: krzysztof.kozlowski@linaro.org
Cc: broonie@kernel.org, devicetree@vger.kernel.org,
	jerry.huang@nxp.com, krzysztof.kozlowski+dt@linaro.org,
	leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	robh+dt@kernel.org, shawnguo@kernel.org,
	Vladimir Oltean <olteanv@gmail.com>,
	Michael Walle <michael@walle.cc>
Subject: Re: [EXT] Re: [PATCH 1/2 v4] dt-bindings: dspi: added for semtech sx1301
Date: Thu, 21 Apr 2022 11:44:21 +0200	[thread overview]
Message-ID: <20220421094421.288672-1-michael@walle.cc> (raw)
In-Reply-To: <f6086989-a4c1-4223-fad0-79bd5719432e@linaro.org>

On 21/04/2022 11:11, Jerry Huang wrote:
>> Please also answer Michael's comments.
>> 
>> [Jerry Huang] I double checked the MikroBus devices, we used two MikcroBus devices:
>> BLE P click: https://www.mikroe.com/ble-p-click
>> BEE click: https://www.mikroe.com/bee-click 
>> Both of them are SPI interface connect to ls1028ardb through MiKcroBus interface.
>> So the name "semtech sx1301" is not correct for this node.
>
> I asked to remove the words "Devicetree bindings" and this was not finished.
> 
> Now you mention that entire name of device is wrong... It's confusing. I
> don't know what device you are describing here. I expect you know. :)
> 
> What is this binding about exactly?

I *think* it's just exposing the mikrobus connector as an spidev device.
There was a former attempt by Vladimir here [1]. Now as it the nature
of such a connector that you can connect a myriad of devices there, it
doesn't really make sense to have a just particular one described. What
happens if that one will switch from spidev to a real driver in the
kernel? So using "spidev" for the compatible would be the first reflex.
But as described in the spidev driver this is plain wrong (and also causes
a warning/info message it) because it should describe the actual hardware.

Thus I proposed to use DT overlays which are loaded according to what
is actually attached to the header, so a real driver could be loaded.

But there *could* be a sane default which then could be replaced in
an DT overlay. Like "mirkobus-socket" or similar, which might expose
spidev. Actually it is more than just SPI, there is GPIO and resets and
I2C. Maybe it should be an MFD? I don't know. But that is something for
the DT maintainers to decide if they'll allow such "generic" devices.

-michael

[1] https://lore.kernel.org/linux-devicetree/20200318001603.9650-13-olteanv@gmail.com/

  parent reply	other threads:[~2022-04-21  9:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  7:31 [PATCH 1/2 v4] dt-bindings: dspi: added for semtech sx1301 Changming Huang
2022-04-20  7:31 ` [PATCH 2/2 v4] arm64: dts: fsl-ls1028a: add dspi2 support Changming Huang
2022-04-20 12:06 ` [PATCH 1/2 v4] dt-bindings: dspi: added for semtech sx1301 Krzysztof Kozlowski
2022-04-21  9:11   ` [EXT] " Jerry Huang
2022-04-21  9:18     ` Krzysztof Kozlowski
2022-04-21  9:35       ` Jerry Huang
2022-04-21  9:44       ` Michael Walle [this message]
2022-04-21 10:06         ` Jerry Huang
2022-04-21 11:08         ` Krzysztof Kozlowski
2022-04-21 11:56           ` Michael Walle
2022-04-21 14:23         ` Rob Herring
2022-04-21 15:16           ` Michael Walle
2022-04-21 19:08             ` Rob Herring
2022-04-22  2:19               ` Jerry Huang
2022-04-21 14:27     ` Rob Herring
2022-04-20 13:29 ` Rob Herring
2022-04-21  9:12   ` [EXT] " Jerry Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220421094421.288672-1-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jerry.huang@nxp.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).