From: Daniel Kaehn <kaehndan@gmail.com>
To: tiwai@suse.com
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
Daniel Kaehn <kaehndan@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH v2 0/2] Add generic serial MIDI driver using serial bus API
Date: Thu, 21 Apr 2022 12:24:25 -0500 [thread overview]
Message-ID: <20220421172427.703231-1-kaehndan@gmail.com> (raw)
Changes in v2:
- Fix 'snd_serial_generic_write_wakeup' missing static keyword as
reported by the kernel test robot
- Correct 3.125 kBaud -> 31.25 kBaud and 3.84 kBaud -> 38.4 kBaud
in documentation for MIDI
Reported-by: kernel test robot <lkp@intel.com>
Background as included in the initial cover letter:
Generic serial MIDI driver adding support for using serial devices
compatible with the serial bus as raw MIDI devices, allowing using
additional serial devices not compatible with the existing
serial-u16550 driver. Supports only setting standard serial baudrates on
the underlying serial device; however, the underlying serial device can
be configured so that a requested 38.4 kBaud is actually the standard MIDI
31.25 kBaud. Supports DeviceTree configuration.
The need for this driver arose from a project using a Raspberry Pi4 which
needed to receive and send raw MIDI with low latency. The pl011 UART
used is not compatible with the existing serial MIDI driver made for
u16550-style devices. Using a userspace program such as ttymidi to feed
input from the TTY device to a virtual ALSA MIDI device was functional,
but not ideal.
I am not sure if a MIDI driver needing the mentioned 'hack' to clock
38.4 kBaud down to the standard MIDI baud is permissible in the mainline
kernel, but am submitting nevertheless in case it is useful. To my knowledge,
it doesn't seem that there would be any way for this driver to manually
configure a serial port to 31.25 kBaud using the serial bus API (please
correct me f I'm wrong). In my use case, I am actually configuring one port
to run at 115.2 kBaud for faster communication with a custom onboard MIDI controller.
Daniel Kaehn (2):
dt-bindings: sound: Add generic serial MIDI device
Add generic serial MIDI driver using serial bus API
.../devicetree/bindings/sound/serialmidi.yaml | 41 +++
sound/drivers/Kconfig | 17 +
sound/drivers/Makefile | 2 +
sound/drivers/serial-generic.c | 344 ++++++++++++++++++
4 files changed, 404 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/serialmidi.yaml
create mode 100644 sound/drivers/serial-generic.c
base-commit: b253435746d9a4a701b5f09211b9c14d3370d0da
--
2.35.1
next reply other threads:[~2022-04-21 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 17:24 Daniel Kaehn [this message]
2022-04-21 17:24 ` [PATCH v2 1/2] dt-bindings: sound: Add generic serial MIDI device Daniel Kaehn
2022-04-21 17:24 ` [PATCH v2 2/2] Add generic serial MIDI driver using serial bus API Daniel Kaehn
2022-04-22 14:27 ` Takashi Iwai
2022-04-22 16:52 ` Daniel Kaehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421172427.703231-1-kaehndan@gmail.com \
--to=kaehndan@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).