From: Zhiyong Tao <zhiyong.tao@mediatek.com>
To: <lee.jones@linaro.org>, <robh+dt@kernel.org>,
<matthias.bgg@gmail.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <eddie.huang@mediatek.com>,
<a.zummo@towertech.it>, <alexandre.belloni@bootlin.com>,
<fshao@chromium.org>
Cc: <srv_heupstream@mediatek.com>, <hui.liu@mediatek.com>,
<tinghan.shen@mediatek.com>, <zhiyong.tao@mediatek.com>,
<hsin-hsiung.wang@mediatek.com>, <sean.wang@mediatek.com>,
<macpaul.lin@mediatek.com>, <wen.su@mediatek.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-rtc@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue
Date: Fri, 22 Apr 2022 11:34:23 +0800 [thread overview]
Message-ID: <20220422033423.11702-2-zhiyong.tao@mediatek.com> (raw)
In-Reply-To: <20220422033423.11702-1-zhiyong.tao@mediatek.com>
From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
Fix pwrap FSM timeout issue which leads the system crash on GFX VSRAM
power on.
Add a usleep delay to avoid busy read for the H/W status.
For avoiding the system behavior(ex. disable interrupt in suspend/resume
flow, schedule block task)cause if (time_after()) be turn first,
we change it after sleep delay.
Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
old mode 100644
new mode 100755
index 952bc554f443..ac7139a67e87
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -12,6 +12,7 @@
#include <linux/platform_device.h>
#include <linux/regmap.h>
#include <linux/reset.h>
+#include <linux/delay.h>
#define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4
#define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10
@@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
timeout = jiffies + usecs_to_jiffies(10000);
do {
- if (time_after(jiffies, timeout))
- return fp(wrp) ? 0 : -ETIMEDOUT;
if (fp(wrp))
return 0;
+
+ usleep_range(10, 11);
+
+ if (time_after(jiffies, timeout))
+ return fp(wrp) ? 0 : -ETIMEDOUT;
} while (1);
}
--
2.18.0
next prev parent reply other threads:[~2022-04-22 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 3:34 [PATCH v2 0/1] Mediatek PMIC patch Zhiyong Tao
2022-04-22 3:34 ` Zhiyong Tao [this message]
2022-04-22 8:27 ` [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue Rex-BC Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422033423.11702-2-zhiyong.tao@mediatek.com \
--to=zhiyong.tao@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fshao@chromium.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tinghan.shen@mediatek.com \
--cc=wen.su@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).