* [PATCH v2 0/1] Mediatek PMIC patch @ 2022-04-22 3:34 Zhiyong Tao 2022-04-22 3:34 ` [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue Zhiyong Tao 0 siblings, 1 reply; 3+ messages in thread From: Zhiyong Tao @ 2022-04-22 3:34 UTC (permalink / raw) To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: srv_heupstream, hui.liu, tinghan.shen, zhiyong.tao, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek This patch fix pwrap time out issue. Changes in patch v2: 1)add explation commit message on the patch. Zhiyong.Tao (1): pwrap: mediatek: fix FSM timeout issue drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c -- 2.18.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue 2022-04-22 3:34 [PATCH v2 0/1] Mediatek PMIC patch Zhiyong Tao @ 2022-04-22 3:34 ` Zhiyong Tao 2022-04-22 8:27 ` Rex-BC Chen 0 siblings, 1 reply; 3+ messages in thread From: Zhiyong Tao @ 2022-04-22 3:34 UTC (permalink / raw) To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: srv_heupstream, hui.liu, tinghan.shen, zhiyong.tao, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com> Fix pwrap FSM timeout issue which leads the system crash on GFX VSRAM power on. Add a usleep delay to avoid busy read for the H/W status. For avoiding the system behavior(ex. disable interrupt in suspend/resume flow, schedule block task)cause if (time_after()) be turn first, we change it after sleep delay. Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com> --- drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c old mode 100644 new mode 100755 index 952bc554f443..ac7139a67e87 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -12,6 +12,7 @@ #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/reset.h> +#include <linux/delay.h> #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4 #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10 @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp, timeout = jiffies + usecs_to_jiffies(10000); do { - if (time_after(jiffies, timeout)) - return fp(wrp) ? 0 : -ETIMEDOUT; if (fp(wrp)) return 0; + + usleep_range(10, 11); + + if (time_after(jiffies, timeout)) + return fp(wrp) ? 0 : -ETIMEDOUT; } while (1); } -- 2.18.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue 2022-04-22 3:34 ` [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue Zhiyong Tao @ 2022-04-22 8:27 ` Rex-BC Chen 0 siblings, 0 replies; 3+ messages in thread From: Rex-BC Chen @ 2022-04-22 8:27 UTC (permalink / raw) To: Zhiyong Tao, lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie, eddie.huang, a.zummo, alexandre.belloni, fshao Cc: srv_heupstream, hui.liu, tinghan.shen, hsin-hsiung.wang, sean.wang, macpaul.lin, wen.su, devicetree, linux-kernel, linux-rtc, Project_Global_Chrome_Upstream_Group, linux-arm-kernel, linux-mediatek On Fri, 2022-04-22 at 11:34 +0800, Zhiyong Tao wrote: > From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com> > > Fix pwrap FSM timeout issue which leads the system crash on GFX VSRAM > power on. > Add a usleep delay to avoid busy read for the H/W status. > For avoiding the system behavior(ex. disable interrupt in > suspend/resume > flow, schedule block task)cause if (time_after()) be turn first, > we change it after sleep delay. > Hello Zhiyong, if this is a fix patch. IMO, you should add Fixes tag: Fixes: 1f022d84bd19 ("soc: mediatek: Add PMIC wrapper for MT8135 and MT8173 SoCs") > Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com> > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > mode change 100644 => 100755 drivers/soc/mediatek/mtk-pmic-wrap.c > File mode should be 100644. BRs, Rex > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c > b/drivers/soc/mediatek/mtk-pmic-wrap.c > old mode 100644 > new mode 100755 > index 952bc554f443..ac7139a67e87 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -12,6 +12,7 @@ > #include <linux/platform_device.h> > #include <linux/regmap.h> > #include <linux/reset.h> > +#include <linux/delay.h> > > #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN 0x4 > #define PWRAP_MT8135_BRIDGE_WACS3_EN 0x10 > @@ -1197,10 +1198,13 @@ static int pwrap_wait_for_state(struct > pmic_wrapper *wrp, > timeout = jiffies + usecs_to_jiffies(10000); > > do { > - if (time_after(jiffies, timeout)) > - return fp(wrp) ? 0 : -ETIMEDOUT; > if (fp(wrp)) > return 0; > + > + usleep_range(10, 11); > + > + if (time_after(jiffies, timeout)) > + return fp(wrp) ? 0 : -ETIMEDOUT; > } while (1); > } > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-22 8:27 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-04-22 3:34 [PATCH v2 0/1] Mediatek PMIC patch Zhiyong Tao 2022-04-22 3:34 ` [PATCH v2 1/1] pwrap: mediatek: fix FSM timeout issue Zhiyong Tao 2022-04-22 8:27 ` Rex-BC Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).