From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Luka Perkov <luka.perkov@sartura.hr>,
Robert Marko <robert.marko@sartura.hr>
Subject: [PATCH net-next 3/5] net: ipqess: Add out-of-band DSA tagging support
Date: Fri, 22 Apr 2022 20:03:03 +0200 [thread overview]
Message-ID: <20220422180305.301882-4-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20220422180305.301882-1-maxime.chevallier@bootlin.com>
On the IPQ4019, there's an 5 ports switch connected to the CPU through
the IPQESS Ethernet controller. The way the DSA tag is sent-out to that
switch is through the DMA descriptor, due to how tightly it is
integrated with the switch.
This commit uses the out-of-band tagging protocol to get the outgoing
port index for each SKB, and reports it back in the skb->shinfo on the
RX side based on information located in the descriptor.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/ethernet/qualcomm/ipqess/ipqess.c | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/net/ethernet/qualcomm/ipqess/ipqess.c b/drivers/net/ethernet/qualcomm/ipqess/ipqess.c
index 4ecb8c65417b..32a5cdd1c063 100644
--- a/drivers/net/ethernet/qualcomm/ipqess/ipqess.c
+++ b/drivers/net/ethernet/qualcomm/ipqess/ipqess.c
@@ -20,6 +20,7 @@
#include <linux/skbuff.h>
#include <linux/vmalloc.h>
#include <net/checksum.h>
+#include <net/dsa.h>
#include <net/ip6_checksum.h>
#include "ipqess.h"
@@ -399,6 +400,11 @@ static int ipqess_rx_poll(struct ipqess_rx_ring *rx_ring, int budget)
skb->protocol = eth_type_trans(skb, rx_ring->ess->netdev);
skb_record_rx_queue(skb, rx_ring->ring_id);
+ if (netdev_uses_dsa(rx_ring->ess->netdev)) {
+ skb_shinfo(skb)->dsa_tag_info.dp =
+ FIELD_GET(IPQESS_RRD_PORT_ID_MASK, rd->rrd1);
+ }
+
if (rd->rrd6 & IPQESS_RRD_CSUM_FAIL_MASK)
skb_checksum_none_assert(skb);
else
@@ -706,6 +712,21 @@ static void ipqess_rollback_tx(struct ipqess *eth,
tx_ring->head = start_index;
}
+static void ipqess_process_dsa_tag_sh(struct ipqess *ess, struct sk_buff *skb,
+ u32 *word3)
+{
+ struct skb_shared_info *shinfo = skb_shinfo(skb);
+ struct dsa_tag_info *tag_info = &shinfo->dsa_tag_info;
+
+ if (!netdev_uses_dsa(ess->netdev) ||
+ tag_info->proto != DSA_TAG_PROTO_OOB)
+ return;
+
+ *word3 |= tag_info->dp << IPQESS_TPD_PORT_BITMAP_SHIFT;
+ *word3 |= BIT(IPQESS_TPD_FROM_CPU_SHIFT);
+ *word3 |= 0x3e << IPQESS_TPD_PORT_BITMAP_SHIFT;
+}
+
static int ipqess_tx_map_and_fill(struct ipqess_tx_ring *tx_ring,
struct sk_buff *skb)
{
@@ -716,6 +737,8 @@ static int ipqess_tx_map_and_fill(struct ipqess_tx_ring *tx_ring,
u16 len;
int i;
+ ipqess_process_dsa_tag_sh(tx_ring->ess, skb, &word3);
+
if (skb_is_gso(skb)) {
if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4) {
lso_word1 |= IPQESS_TPD_IPV4_EN;
--
2.35.1
next prev parent reply other threads:[~2022-04-22 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 18:03 [PATCH net-next 0/5] net: ipqess: introduce Qualcomm IPQESS driver Maxime Chevallier
2022-04-22 18:03 ` [PATCH net-next 1/5] net: ipqess: introduce the " Maxime Chevallier
2022-04-22 20:19 ` Andrew Lunn
2022-04-26 13:59 ` Maxime Chevallier
2022-04-22 18:03 ` [PATCH net-next 2/5] net: dsa: add out-of-band tagging protocol Maxime Chevallier
2022-04-22 18:28 ` Florian Fainelli
2022-04-26 13:57 ` Maxime Chevallier
2022-04-26 18:52 ` Vladimir Oltean
2022-04-22 18:03 ` Maxime Chevallier [this message]
2022-04-22 18:03 ` [PATCH net-next 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Maxime Chevallier
2022-04-22 21:10 ` Rob Herring
2022-04-23 17:49 ` Krzysztof Kozlowski
2022-04-26 14:02 ` Maxime Chevallier
2022-04-22 18:03 ` [PATCH net-next 5/5] ARM: dts: qcom: ipq4019: Add description for the " Maxime Chevallier
2022-04-22 20:29 ` [PATCH net-next 0/5] net: ipqess: introduce Qualcomm IPQESS driver Andrew Lunn
2022-04-26 12:12 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422180305.301882-4-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).