devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver
Date: Fri, 22 Apr 2022 18:53:52 -0700	[thread overview]
Message-ID: <20220423015354.6558BC385A0@smtp.kernel.org> (raw)
In-Reply-To: <20220422230013.1332993-2-bjorn.andersson@linaro.org>

Quoting Bjorn Andersson (2022-04-22 16:00:13)
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> new file mode 100644
> index 000000000000..16bfe62efca2
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -0,0 +1,7451 @@
[...]
> +static struct clk_branch gcc_video_vcodec_throttle_clk = {
> +       .halt_reg = 0x28020,
> +       .halt_check = BRANCH_HALT_SKIP,
> +       .hwcg_reg = 0x28020,
> +       .hwcg_bit = 1,
> +       .clkr = {
> +               .enable_reg = 0x28020,
> +               .enable_mask = BIT(0),
> +               .hw.init = &(struct clk_init_data){

The clk_init_data can be const too, right?

> +                       .name = "gcc_video_vcodec_throttle_clk",
> +                       .ops = &clk_branch2_ops,
> +               },
> +       },
> +};

  reply	other threads:[~2022-04-23  1:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 23:00 [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings Bjorn Andersson
2022-04-22 23:00 ` [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver Bjorn Andersson
2022-04-23  1:53   ` Stephen Boyd [this message]
2022-04-23  1:48 ` [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings Stephen Boyd
2022-04-23  3:02   ` Bjorn Andersson
2022-04-23  3:13     ` Stephen Boyd
2022-04-23  3:43       ` Bjorn Andersson
2022-04-25 22:34         ` Stephen Boyd
2022-04-28 15:44           ` Dmitry Baryshkov
2022-04-28 16:01             ` Bjorn Andersson
2022-04-28 16:24               ` Dmitry Baryshkov
2022-04-28 19:12                 ` Bjorn Andersson
2022-05-03 19:19                   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220423015354.6558BC385A0@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).