From: kernel test robot <lkp@intel.com>
To: Quan Nguyen <quan@os.amperecomputing.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thu Nguyen <thu@os.amperecomputing.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro MFD driver
Date: Sat, 23 Apr 2022 05:19:22 +0800 [thread overview]
Message-ID: <202204230554.4528TqPu-lkp@intel.com> (raw)
In-Reply-To: <20220422024653.2199489-9-quan@os.amperecomputing.com>
Hi Quan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on groeck-staging/hwmon-next lee-mfd/for-mfd-next v5.18-rc3 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git c50c29a806113614098efd8da9fd7b48d605ba45
config: arm-randconfig-r004-20220422 (https://download.01.org/0day-ci/archive/20220423/202204230554.4528TqPu-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5bd87350a5ae429baf8f373cb226a57b62f87280)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/09ec873f0dd4611cb2df0150923d8906b9c5b2d1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220422-105732
git checkout 09ec873f0dd4611cb2df0150923d8906b9c5b2d1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mach-at91/ drivers/hwmon/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/hwmon/smpro-hwmon.c:376:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/hwmon/smpro-hwmon.c:376:3: note: insert 'break;' to avoid fall-through
default:
^
break;
1 warning generated.
vim +376 drivers/hwmon/smpro-hwmon.c
e1354080fc83378 Quan Nguyen 2022-04-22 359
e1354080fc83378 Quan Nguyen 2022-04-22 360 static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type,
e1354080fc83378 Quan Nguyen 2022-04-22 361 u32 attr, int channel)
e1354080fc83378 Quan Nguyen 2022-04-22 362 {
e1354080fc83378 Quan Nguyen 2022-04-22 363 const struct smpro_hwmon *hwmon = data;
e1354080fc83378 Quan Nguyen 2022-04-22 364 unsigned int value;
e1354080fc83378 Quan Nguyen 2022-04-22 365 int ret;
e1354080fc83378 Quan Nguyen 2022-04-22 366
e1354080fc83378 Quan Nguyen 2022-04-22 367 switch (type) {
e1354080fc83378 Quan Nguyen 2022-04-22 368 case hwmon_temp:
e1354080fc83378 Quan Nguyen 2022-04-22 369 switch (attr) {
e1354080fc83378 Quan Nguyen 2022-04-22 370 case hwmon_temp_input:
e1354080fc83378 Quan Nguyen 2022-04-22 371 case hwmon_temp_label:
e1354080fc83378 Quan Nguyen 2022-04-22 372 case hwmon_temp_crit:
e1354080fc83378 Quan Nguyen 2022-04-22 373 ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value);
e1354080fc83378 Quan Nguyen 2022-04-22 374 if (ret || value == 0xFFFF)
e1354080fc83378 Quan Nguyen 2022-04-22 375 return 0;
e1354080fc83378 Quan Nguyen 2022-04-22 @376 default:
e1354080fc83378 Quan Nguyen 2022-04-22 377 break;
e1354080fc83378 Quan Nguyen 2022-04-22 378 }
e1354080fc83378 Quan Nguyen 2022-04-22 379 break;
e1354080fc83378 Quan Nguyen 2022-04-22 380 default:
e1354080fc83378 Quan Nguyen 2022-04-22 381 break;
e1354080fc83378 Quan Nguyen 2022-04-22 382 }
e1354080fc83378 Quan Nguyen 2022-04-22 383
e1354080fc83378 Quan Nguyen 2022-04-22 384 return 0444;
e1354080fc83378 Quan Nguyen 2022-04-22 385 }
e1354080fc83378 Quan Nguyen 2022-04-22 386
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-04-22 22:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 2:46 [PATCH v8 0/9] Add Ampere's Altra SMPro MFD and its child drivers Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 1/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 2/9] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 3/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Quan Nguyen
2022-04-22 6:20 ` Greg Kroah-Hartman
2022-04-22 14:43 ` Quan Nguyen
2022-04-22 14:57 ` Greg Kroah-Hartman
2022-04-22 17:07 ` Darren Hart
2022-04-22 23:21 ` Quan Nguyen
2022-06-01 8:21 ` Quan Nguyen
2022-06-01 9:33 ` Greg Kroah-Hartman
2022-06-02 9:36 ` Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 4/9] docs: misc-devices: (smpro-errmon) Add documentation Quan Nguyen
2022-04-22 6:27 ` Bagas Sanjaya
2022-04-22 2:46 ` [PATCH v8 5/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 6/9] docs: misc-devices: (smpro-misc) Add documentation Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 7/9] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 8/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro " Quan Nguyen
2022-04-22 21:19 ` kernel test robot [this message]
2022-06-15 22:14 ` Lee Jones
2022-06-29 9:23 ` Quan Nguyen
2022-04-22 2:46 ` [PATCH v8 9/9] docs: ABI: testing: Document the Ampere Altra Family's SMpro sysfs interfaces Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204230554.4528TqPu-lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
--cc=thu@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).