From: Richard Cochran <richardcochran@gmail.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 5/5] net: lan966x: Add support for PTP_PF_EXTTS
Date: Sun, 24 Apr 2022 08:09:09 -0700 [thread overview]
Message-ID: <20220424150909.GA29569@hoboy.vegasvil.org> (raw)
In-Reply-To: <20220424145824.2931449-6-horatiu.vultur@microchip.com>
On Sun, Apr 24, 2022 at 04:58:24PM +0200, Horatiu Vultur wrote:
> @@ -321,6 +321,63 @@ irqreturn_t lan966x_ptp_irq_handler(int irq, void *args)
> return IRQ_HANDLED;
> }
>
> +irqreturn_t lan966x_ptp_ext_irq_handler(int irq, void *args)
> +{
> + struct lan966x *lan966x = args;
> + struct lan966x_phc *phc;
> + unsigned long flags;
> + u64 time = 0;
> + time64_t s;
> + int pin, i;
> + s64 ns;
> +
> + if (!(lan_rd(lan966x, PTP_PIN_INTR)))
> + return IRQ_NONE;
> +
> + /* Go through all domains and see which pin generated the interrupt */
> + for (i = 0; i < LAN966X_PHC_COUNT; ++i) {
> + struct ptp_clock_event ptp_event = {0};
> +
> + phc = &lan966x->phc[i];
> + pin = ptp_find_pin(phc->clock, PTP_PF_EXTTS, 0);
Not safe to call ptp_find_pin() from ISR. See comment in include/linux/ptp_clock_kernel.h
Thanks,
Richard
next prev parent reply other threads:[~2022-04-24 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 14:58 [PATCH net-next 0/5] net: lan966x: Add support for PTP programmable pins Horatiu Vultur
2022-04-24 14:58 ` [PATCH net-next 1/5] dt-bindings: net: lan966x: Extend with the ptp external interrupt Horatiu Vultur
2022-04-24 14:58 ` [PATCH net-next 2/5] net: lan966x: Change the PTP pin used to read/write the PHC Horatiu Vultur
2022-04-24 14:58 ` [PATCH net-next 3/5] net: lan966x: Add registers used to configure the PTP pin Horatiu Vultur
2022-04-24 14:58 ` [PATCH net-next 4/5] net: lan966x: Add support for PTP_PF_PEROUT Horatiu Vultur
2022-04-24 14:58 ` [PATCH net-next 5/5] net: lan966x: Add support for PTP_PF_EXTTS Horatiu Vultur
2022-04-24 15:09 ` Richard Cochran [this message]
2022-04-25 20:31 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220424150909.GA29569@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).