From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: jdelvare@suse.com, robh+dt@kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: Document adt7475 pin-function properties
Date: Sun, 24 Apr 2022 09:52:09 -0700 [thread overview]
Message-ID: <20220424165209.GA748231@roeck-us.net> (raw)
In-Reply-To: <20220323034056.260455-2-chris.packham@alliedtelesis.co.nz>
On Wed, Mar 23, 2022 at 04:40:54PM +1300, Chris Packham wrote:
> The adt7473, adt7475, adt7476 and adt7490 have pins that can be used for
> different functions. Add bindings so that it is possible to describe
> what pin functions are intended by the hardware design.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Still waiting for DT maintainer approval.
Guenter
> ---
>
> Notes:
> Changes in v3:
> - None
> Changes in v2:
> - Add review from Krzysztof
>
> .../devicetree/bindings/hwmon/adt7475.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> index 7d9c083632b9..22beb37f1bf1 100644
> --- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> @@ -61,6 +61,26 @@ patternProperties:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> + "adi,pin(5|10)-function":
> + description: |
> + Configures the function for pin 5 on the adi,adt7473 and adi,adt7475. Or
> + pin 10 on the adi,adt7476 and adi,adt7490.
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - pwm2
> + - smbalert#
> +
> + "adi,pin(9|14)-function":
> + description: |
> + Configures the function for pin 9 on the adi,adt7473 and adi,adt7475. Or
> + pin 14 on the adi,adt7476 and adi,adt7490
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - tach4
> + - therm#
> + - smbalert#
> + - gpio
> +
> required:
> - compatible
> - reg
> @@ -79,6 +99,8 @@ examples:
> adi,bypass-attenuator-in0 = <1>;
> adi,bypass-attenuator-in1 = <0>;
> adi,pwm-active-state = <1 0 1>;
> + adi,pin10-function = "smbalert#";
> + adi,pin14-function = "tach4";
> };
> };
>
next prev parent reply other threads:[~2022-04-24 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 3:40 [PATCH v3 0/3] hwmon: (adt7475) pin configuration Chris Packham
2022-03-23 3:40 ` [PATCH v3 1/3] dt-bindings: hwmon: Document adt7475 pin-function properties Chris Packham
2022-04-24 16:52 ` Guenter Roeck [this message]
2022-05-02 4:35 ` Guenter Roeck
2022-03-23 3:40 ` [PATCH v3 2/3] hwmon: (adt7475) Add support for pin configuration Chris Packham
2022-04-24 16:53 ` Guenter Roeck
2022-05-02 4:36 ` Guenter Roeck
2022-03-23 3:40 ` [PATCH v3 3/3] hwmon: (adt7475) Use enum chips when loading attenuator settings Chris Packham
2022-04-24 16:54 ` Guenter Roeck
2022-05-02 4:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220424165209.GA748231@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).