From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201E5C43217 for ; Mon, 25 Apr 2022 16:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237965AbiDYQ2T (ORCPT ); Mon, 25 Apr 2022 12:28:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243526AbiDYQ1x (ORCPT ); Mon, 25 Apr 2022 12:27:53 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86A4D11F961 for ; Mon, 25 Apr 2022 09:24:49 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id i62so1651864pgd.6 for ; Mon, 25 Apr 2022 09:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fy4scNdR+gQe8khm9Rf8E41vItskGz3mg6jdYBjtzmk=; b=MAjwXVtS0TOSth3fYjCdTEttJJ5Dk25IYowuZJb4odyaSAWH+UPiIuqbb9ufRknlu3 KbXXbzOG5/8YVBro2WrgjiRxZ1707r9gW13Jr6pxpFmEPVoo6nomoygPlXyEwCnF2KAA a813mlSQSL0uJ+Q33IarwNSLZm2mcPaeQfhavx7/bj5+eOhuuTx8m2MLaBkZRaQ+uEF1 /Y6IzkWpvj9pXwUmT1X2C3rZUu+YKuu06hlk1Fj1IbgBDYzAhGK0rEqh2buOuUKDhKTS kc5H4g8dCAaCzwiM4MlE+o7aEdByk7yNeVleJj9LVZ0tJvFYiLx+PH7RNz5K06wbhHgR +DvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fy4scNdR+gQe8khm9Rf8E41vItskGz3mg6jdYBjtzmk=; b=us/iJ6Kd5U3dNS5wWEzxZtwYNO7R5vrsA2ImBNrTFj0COOCTKE1XpBKO3rkpkm+w71 qnyqKkRFwGX1iv5hemtOfIcc/lFjF9MlKsTRBv6uYT/8YMU3QIKgsHSdl27gd/gTTgus X47ADOtY2KLP/gfd/xoKDfFetiuNJh4mD9ggtDqUT0EOg1oAcJsn6o3ceD39wFwjoObs Gjzir51oZXW43sZaMGRzsosYSIEbq5D3u3iuttzdsdtLWNhJG906jd9++BeUI5P+F9F7 jN7dA2nSdxNRMLFUMm6ObhDBJCaJobhCtr3Z7jzy61m1peameEruWoYfDnZcMVvvI9aB Ia/A== X-Gm-Message-State: AOAM532KVSNdgDkdoriPPFvEyX7ohUSgizHmDa8Ho9w1o3C0tlnqwJR0 AbnrW5uq3Q+uqy8xq8sWLzIqGGtaS3c6RA== X-Google-Smtp-Source: ABdhPJy3+eXGqclAEFMNVelhhNbF0vgEqU5TGB4C+yC8sRaVH5zFyeHk8OdGfj3X4QNhjN1GPpxDCw== X-Received: by 2002:a63:a61:0:b0:39c:b654:b753 with SMTP id z33-20020a630a61000000b0039cb654b753mr15440285pgk.117.1650903889024; Mon, 25 Apr 2022 09:24:49 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id u2-20020a62d442000000b0050d404f837fsm3822645pfl.156.2022.04.25.09.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 09:24:48 -0700 (PDT) Date: Mon, 25 Apr 2022 09:24:46 -0700 From: Stephen Hemminger To: Wells Lu Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, pabeni@redhat.com, krzk+dt@kernel.org, roopa@nvidia.com, andrew@lunn.ch, edumazet@google.com, wells.lu@sunplus.com Subject: Re: [PATCH net-next v9 2/2] net: ethernet: Add driver for Sunplus SP7021 Message-ID: <20220425092446.477bd8f5@hermes.local> In-Reply-To: <1650882640-7106-3-git-send-email-wellslutw@gmail.com> References: <1650882640-7106-1-git-send-email-wellslutw@gmail.com> <1650882640-7106-3-git-send-email-wellslutw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 25 Apr 2022 18:30:40 +0800 Wells Lu wrote: > diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.h b/drivers/net/ethernet/sunplus/spl2sw_driver.h > new file mode 100644 > index 000000000..5f177b3af > --- /dev/null > +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright Sunplus Technology Co., Ltd. > + * All rights reserved. > + */ > + > +#ifndef __SPL2SW_DRIVER_H__ > +#define __SPL2SW_DRIVER_H__ > + > +#define SPL2SW_RX_NAPI_WEIGHT 16 > +#define SPL2SW_TX_NAPI_WEIGHT 16 Why define your own? there is NAPI_POLL_WEIGHT already defined in netdevice.h