From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BAD6C433F5 for ; Mon, 25 Apr 2022 08:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235863AbiDYIbq (ORCPT ); Mon, 25 Apr 2022 04:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235483AbiDYIb1 (ORCPT ); Mon, 25 Apr 2022 04:31:27 -0400 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3CF7DF99; Mon, 25 Apr 2022 01:28:21 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id E502A240003; Mon, 25 Apr 2022 08:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650875300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M1PvE0KJAkJstROW5DfWV0jdUqZeR3ZX64wIRcBKqWY=; b=dpL/VBGvBTatHJeEf85vfiHwjVsQlEtKqpgroYG1gYeOzvSvQ2Lsmz50OF8KUMfCrenWYP JEbmphFdkakM5V2i7I8WF8cdjM5c0TcGnH7o0dloIHpXPp1KjdtjJR3tKKTt5cFmta/eC3 wX7ECWHgqoLeXnjnqhTldCn5sjgS32lY3+XSwf8MFl95/Z7R2etb9jgh1EqVXdX6Fd1jLN rAbhy5h5LnKEDDLESxZKD71befHkpwMcPc3HvfGPC4gKUUwYXg2ZVuPBLd6/i13PZP/7nO bWcUHYFjSbJBbEEu3M3TpSjKJzaDqNUuMFYoxEoIIwPnYAxbJnF5ZFwZR7N0Xg== Date: Mon, 25 Apr 2022 10:28:16 +0200 From: Miquel Raynal To: Vincent Whitchurch Cc: kernel test robot , "vigneshr@ti.com" , "richard@nod.at" , "joern@lazybastard.org" , "kbuild-all@lists.01.org" , kernel , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "frowand.list@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings Message-ID: <20220425102816.54619c66@xps13> In-Reply-To: <20220414090402.GA11067@axis.com> References: <20220412135302.1682890-5-vincent.whitchurch@axis.com> <202204131446.omJ5mC54-lkp@intel.com> <20220414090402.GA11067@axis.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Vincent, vincent.whitchurch@axis.com wrote on Thu, 14 Apr 2022 11:04:02 +0200: > On Wed, Apr 13, 2022 at 08:45:59AM +0200, kernel test robot wrote: > > All errors (new ones prefixed by >>): > >=20 > > In file included from include/linux/io.h:13, > > from drivers/mtd/devices/phram.c:21: > > drivers/mtd/devices/phram.c: In function 'register_device': =20 > > >> arch/sh/include/asm/io.h:274:33: error: expected expression before '= do' =20 > > 274 | #define iounmap(addr) do { } while (0) > > | ^~ > > drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iou= nmap' > > 150 | cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.= priv); > > | ^~~~~~~ > > drivers/mtd/devices/phram.c: In function 'phram_remove': =20 > > >> arch/sh/include/asm/io.h:274:33: error: expected expression before '= do' =20 > > 274 | #define iounmap(addr) do { } while (0) > > | ^~ > > drivers/mtd/devices/phram.c:372:53: note: in expansion of macro 'iou= nmap' > > 372 | phram->cached ? memunmap(phram->mtd.priv) : iounmap(= phram->mtd.priv); > > | ^~~~~~~ > >=20 > >=20 > > vim +/do +274 arch/sh/include/asm/io.h > >=20 > > d57d64080ddc0f Paul Mundt 2010-01-19 272 =20 > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 273 #else /* CONFIG_MMU */ > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 @274 #define iounmap(addr)= do { } while (0) > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 275 #define ioremap(offse= t, size) ((void __iomem *)(unsigned long)(offset)) > > 13f1fc870dd747 Christoph Hellwig 2020-07-14 276 #endif /* CONFIG_MMU = */ > > d627a2ebd1a303 Paul Mundt 2010-01-28 277 =20 >=20 > Thank you for the report. This patch could certainly be changed to work > around this, but ISTM that the right fix is in the SH header file, since > the problem could hit in other cases too. I've posted a fix here now: >=20 > https://lore.kernel.org/lkml/20220414081257.1487499-1-vincent.whitchurch= @axis.com/ Looks good to me but I don't want to be the one "carrying" new compile errors so I'll drop the series for now, until you get this patch applied. Please then just resend the series with this thread mentioned and I'll take it back. Thanks, Miqu=C3=A8l