* [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
@ 2022-04-25 13:35 Rob Herring
2022-04-25 18:13 ` Krzysztof Kozlowski
2022-04-25 19:32 ` Stephen Boyd
0 siblings, 2 replies; 6+ messages in thread
From: Rob Herring @ 2022-04-25 13:35 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Michael Turquette, Stephen Boyd,
Krzysztof Kozlowski, Taniya Das
Cc: Ansuel Smith, linux-arm-msm, linux-clk, devicetree, linux-kernel
The compatible string should be 'qcom,gcc-apq8064', not
'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
Cc: Ansuel Smith <ansuelsmth@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
index 97936411b6b4..9910a3e033bb 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
@@ -25,7 +25,7 @@ description: |
properties:
compatible:
- const: qcom,gcc-apq8084
+ const: qcom,gcc-apq8064
nvmem-cells:
minItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
2022-04-25 13:35 [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string Rob Herring
@ 2022-04-25 18:13 ` Krzysztof Kozlowski
2022-04-25 19:32 ` Stephen Boyd
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 18:13 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson, Andy Gross, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski, Taniya Das
Cc: Ansuel Smith, linux-arm-msm, linux-clk, devicetree, linux-kernel
On 25/04/2022 15:35, Rob Herring wrote:
> The compatible string should be 'qcom,gcc-apq8064', not
> 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
>
> Cc: Ansuel Smith <ansuelsmth@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
Thanks Rob!
Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064
Documentation")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
2022-04-25 13:35 [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string Rob Herring
2022-04-25 18:13 ` Krzysztof Kozlowski
@ 2022-04-25 19:32 ` Stephen Boyd
2022-04-25 20:23 ` Rob Herring
2022-04-25 20:28 ` Krzysztof Kozlowski
1 sibling, 2 replies; 6+ messages in thread
From: Stephen Boyd @ 2022-04-25 19:32 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski,
Michael Turquette, Rob Herring, Taniya Das
Cc: Ansuel Smith, linux-arm-msm, linux-clk, devicetree, linux-kernel
Quoting Rob Herring (2022-04-25 06:35:27)
> The compatible string should be 'qcom,gcc-apq8064', not
> 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
>
> Cc: Ansuel Smith <ansuelsmth@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> index 97936411b6b4..9910a3e033bb 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> @@ -25,7 +25,7 @@ description: |
>
> properties:
> compatible:
> - const: qcom,gcc-apq8084
> + const: qcom,gcc-apq8064
This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
simplify qcom,gcc-apq8064 Documentation") took the more than just the
compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
the apq8064 file with the single compatible changed.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
2022-04-25 19:32 ` Stephen Boyd
@ 2022-04-25 20:23 ` Rob Herring
2022-04-25 20:31 ` Krzysztof Kozlowski
2022-04-25 20:28 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-04-25 20:23 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski,
Michael Turquette, Taniya Das, Ansuel Smith, linux-arm-msm,
linux-clk, devicetree, linux-kernel
On Mon, Apr 25, 2022 at 12:32:51PM -0700, Stephen Boyd wrote:
> Quoting Rob Herring (2022-04-25 06:35:27)
> > The compatible string should be 'qcom,gcc-apq8064', not
> > 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
> >
> > Cc: Ansuel Smith <ansuelsmth@gmail.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > index 97936411b6b4..9910a3e033bb 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > @@ -25,7 +25,7 @@ description: |
> >
> > properties:
> > compatible:
> > - const: qcom,gcc-apq8084
> > + const: qcom,gcc-apq8064
>
> This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
> that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
> simplify qcom,gcc-apq8064 Documentation") took the more than just the
> compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
> removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
> the apq8064 file with the single compatible changed.
IDK, can someone (Ansuel?) fix this properly?
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
2022-04-25 20:23 ` Rob Herring
@ 2022-04-25 20:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 20:31 UTC (permalink / raw)
To: Rob Herring, Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski,
Michael Turquette, Taniya Das, Ansuel Smith, linux-arm-msm,
linux-clk, devicetree, linux-kernel
On 25/04/2022 22:23, Rob Herring wrote:
>>>
>>> properties:
>>> compatible:
>>> - const: qcom,gcc-apq8084
>>> + const: qcom,gcc-apq8064
>>
>> This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
>> that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
>> simplify qcom,gcc-apq8064 Documentation") took the more than just the
>> compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
>> removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
>> the apq8064 file with the single compatible changed.
>
> IDK, can someone (Ansuel?) fix this properly?
I'll look at this and fix it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string
2022-04-25 19:32 ` Stephen Boyd
2022-04-25 20:23 ` Rob Herring
@ 2022-04-25 20:28 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 20:28 UTC (permalink / raw)
To: Stephen Boyd, Andy Gross, Bjorn Andersson, Krzysztof Kozlowski,
Michael Turquette, Rob Herring, Taniya Das
Cc: Ansuel Smith, linux-arm-msm, linux-clk, devicetree, linux-kernel
On 25/04/2022 21:32, Stephen Boyd wrote:
> Quoting Rob Herring (2022-04-25 06:35:27)
>> The compatible string should be 'qcom,gcc-apq8064', not
>> 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
>>
>> Cc: Ansuel Smith <ansuelsmth@gmail.com>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
>> index 97936411b6b4..9910a3e033bb 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
>> @@ -25,7 +25,7 @@ description: |
>>
>> properties:
>> compatible:
>> - const: qcom,gcc-apq8084
>> + const: qcom,gcc-apq8064
>
> This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
> that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
> simplify qcom,gcc-apq8064 Documentation") took the more than just the
> compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
> removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
> the apq8064 file with the single compatible changed.
Good point, Rob's commit removes entirely qcom,gcc-apq8084 compatible,
which is and was used.
Probably the intention of that commit was to merge apq8064 and apq8084.
The first uses dt-bindings/clock/qcom,gcc-msm8960.h header for IDs. The
second has its own headers, added in mentioned commit.
I am not sure it is worth splitting this into two files. Adding here
enum for 8064 and 8084 should work fine.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-25 20:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-25 13:35 [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string Rob Herring
2022-04-25 18:13 ` Krzysztof Kozlowski
2022-04-25 19:32 ` Stephen Boyd
2022-04-25 20:23 ` Rob Herring
2022-04-25 20:31 ` Krzysztof Kozlowski
2022-04-25 20:28 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).