devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Merello <andrea.merello@gmail.com>
To: jic23@kernel.org, mchehab+huawei@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: lars@metafoo.de, robh+dt@kernel.org, andy.shevchenko@gmail.com,
	matt.ranostay@konsulko.com, ardeleanalex@gmail.com,
	jacopo@jmondi.org, Andrea Merello <andrea.merello@iit.it>
Subject: [v5 07/14] iio: add support for binary attributes
Date: Tue, 26 Apr 2022 15:10:55 +0200	[thread overview]
Message-ID: <20220426131102.23966-8-andrea.merello@gmail.com> (raw)
In-Reply-To: <20220426131102.23966-1-andrea.merello@gmail.com>

From: Andrea Merello <andrea.merello@iit.it>

When a IIO device is registered, the IIO core creates an attribute group on
its own, where it puts the channel attributes, and where it copies the
attributes in indio_dev->info->attrs.

Unfortunately it doesn't take care of binary attributes (i.e. it only
consider indio_dev->info->attrs->attrs, and it ignores
indio_dev->info->attrs->bin_attrs).

Fix this by making the IIO layer take care also of the binary attributes.

Note that while it is necessary to copy the non-binary attributes because
the IIO layer needs more room to add the channels attribute, it should be
enough to assign the bin_attrs pointer to the binary attributes pointed by
indio_dev->info->attrs->bin_attrs.

Signed-off-by: Andrea Merello <andrea.merello@iit.it>
---
 drivers/iio/industrialio-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index aa5f98d3b334..aef30f0b9465 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1567,7 +1567,7 @@ static int iio_device_register_sysfs(struct iio_dev *indio_dev)
 		ret = -ENOMEM;
 		goto error_clear_attrs;
 	}
-	/* Copy across original attributes */
+	/* Copy across original attributes, and point to original binary attributes */
 	if (indio_dev->info->attrs) {
 		memcpy(iio_dev_opaque->chan_attr_group.attrs,
 		       indio_dev->info->attrs->attrs,
@@ -1575,6 +1575,8 @@ static int iio_device_register_sysfs(struct iio_dev *indio_dev)
 		       *attrcount_orig);
 		iio_dev_opaque->chan_attr_group.is_visible =
 			indio_dev->info->attrs->is_visible;
+		iio_dev_opaque->chan_attr_group.bin_attrs =
+			indio_dev->info->attrs->bin_attrs;
 	}
 	attrn = attrcount_orig;
 	/* Add all elements from the list. */
-- 
2.17.1


  parent reply	other threads:[~2022-04-26 13:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 13:10 [v5 00/14] Add support for Bosch BNO055 IMU Andrea Merello
2022-04-26 13:10 ` [v5 01/14] iio: add modifiers for linear acceleration Andrea Merello
2022-04-26 13:10 ` [v5 02/14] iio: document linear acceleration modifiers Andrea Merello
2022-04-26 13:10 ` [v5 03/14] iio: event_monitor: add " Andrea Merello
2022-04-26 13:10 ` [v5 04/14] iio: add modifers for pitch, yaw, roll Andrea Merello
2022-04-26 13:10 ` [v5 05/14] iio: document pitch, yaw, roll modifiers Andrea Merello
2022-04-26 13:10 ` [v5 06/14] iio: event_monitor: add pitch, yaw and " Andrea Merello
2022-04-26 13:10 ` Andrea Merello [this message]
2022-04-26 13:10 ` [v5 08/14] iio: imu: add Bosch Sensortec BNO055 core driver Andrea Merello
2022-04-27 13:22   ` Andy Shevchenko
2022-05-02  9:50     ` Andrea Merello
2022-05-02 10:11       ` Andy Shevchenko
2022-05-02 13:12         ` Andrea Merello
2022-04-26 13:10 ` [v5 09/14] iio: document bno055 private sysfs attributes Andrea Merello
2022-04-26 13:10 ` [v5 10/14] iio: document "serialnumber" sysfs attribute Andrea Merello
2022-04-26 13:10 ` [v5 11/14] dt-bindings: iio/imu: Add Bosch BNO055 Andrea Merello
2022-04-26 13:11 ` [v5 12/14] iio: imu: add BNO055 serdev driver Andrea Merello
2022-04-27  8:10   ` kernel test robot
2022-04-27 13:41     ` Andy Shevchenko
2022-05-03  7:48       ` Andrea Merello
2022-05-03 13:30         ` Andrea Merello
2022-05-03 14:04           ` Andy Shevchenko
2022-04-27 14:24   ` kernel test robot
2022-04-26 13:11 ` [v5 13/14] iio: imu: add BNO055 I2C driver Andrea Merello
2022-04-26 13:11 ` [v5 14/14] docs: iio: add documentation for BNO055 driver Andrea Merello
2022-04-27 13:42 ` [v5 00/14] Add support for Bosch BNO055 IMU Andy Shevchenko
2022-05-01 17:03   ` Jonathan Cameron
2022-05-02  6:33     ` Andrea Merello
2022-05-02  7:47       ` Andy Shevchenko
2022-05-02  8:31         ` Andrea Merello
2022-05-02  8:52           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426131102.23966-8-andrea.merello@gmail.com \
    --to=andrea.merello@gmail.com \
    --cc=andrea.merello@iit.it \
    --cc=andy.shevchenko@gmail.com \
    --cc=ardeleanalex@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.ranostay@konsulko.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).