From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A70AC433EF for ; Tue, 26 Apr 2022 14:02:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241804AbiDZOFT (ORCPT ); Tue, 26 Apr 2022 10:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237262AbiDZOFS (ORCPT ); Tue, 26 Apr 2022 10:05:18 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D9D32EDC; Tue, 26 Apr 2022 07:02:10 -0700 (PDT) Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 78A2BC0008; Tue, 26 Apr 2022 14:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650981728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7PQZCwiv2zEHTrq79VR/VdsVP2v14TZgynrsHMuTV/0=; b=GqrophupVFhOrusBv9A1zJ+E8bt3QYe/6VKg+dF4uAcEDBOcMdPM/ms2t2RY7ms+XfPhqE TKY4kXPXOQxkdjJ9AocBAj4EHj2bGV+Iox7dkQtp4mcFwCBv+15WFpRXnBqyzXo1yG1TWI lcv+9wSjnqcjjiiVWzWmgKgAH86bZCUfQ7QgQHTlQzYALRjxuc2zBNHwstmIrCY0b7WhQ8 mCORk9Kzwq5iFkouEnUyEYEzNqArXLc1B98EoHbOZHaWhlAeE0hqRqjL1X0PYS3B088MDy COySCDCntcmYyoWU3Cd35fvgbjT49Ov9b+H4AFQRCCKUBdYlGgdCJ5wdqDDpFg== Date: Tue, 26 Apr 2022 16:02:06 +0200 From: Maxime Chevallier To: Krzysztof Kozlowski Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Message-ID: <20220426160206.1a8d425c@pc-19.home> In-Reply-To: <34d3bfdc-cf8c-bf63-4f67-57c8d6c9b780@linaro.org> References: <20220422180305.301882-1-maxime.chevallier@bootlin.com> <20220422180305.301882-5-maxime.chevallier@bootlin.com> <34d3bfdc-cf8c-bf63-4f67-57c8d6c9b780@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof On Sat, 23 Apr 2022 19:49:30 +0200 Krzysztof Kozlowski wrote: Thanks a lot for the review, I'll address all your comments in a V2. > On 22/04/2022 20:03, Maxime Chevallier wrote: > > Add the DT binding for the IPQESS Ethernet Controller. This is a > > simple controller, only requiring the phy-mode, interrupts, clocks, > > and possibly a MAC address setting. > > > > Signed-off-by: Maxime Chevallier > > --- > > .../devicetree/bindings/net/qcom,ipqess.yaml | 94 > > +++++++++++++++++++ 1 file changed, 94 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml new file > > mode 100644 index 000000000000..8fec5633692f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > @@ -0,0 +1,94 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/qcom,ipqess.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm IPQ ESS EDMA Ethernet Controller Device Tree > > Bindings > > s/Device Tree Bindings// > > > + > > +allOf: > > + - $ref: "ethernet-controller.yaml#" > > allOf goes after maintainers. > > > + > > +maintainers: > > + - Maxime Chevallier > > + > > +properties: > > + compatible: > > + const: qcom,ipq4019e-ess-edma > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 2 > > + maxItems: 32 > > + description: One interrupt per tx and rx queue, with up to 16 > > queues. + > > + clocks: > > + maxItems: 1 > > + > > + phy-mode: true > > + > > + fixed-link: true > > + > > + mac-address: true > > You don't need all these three. They come from ethernet-controller and > you use unevaluatedProperties. > > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - phy-mode > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + gmac: ethernet@c080000 { > > + compatible = "qcom,ipq4019-ess-edma"; > > + reg = <0xc080000 0x8000>; > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + > > + status = "okay"; > > No status in the example. > > > + > > + phy-mode = "internal"; > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + pause; > > + asym-pause; > > + }; > > + }; > > + > > +... > > > Best regards, > Krzysztof Best Regards, Maxime