From: Miles Chen <miles.chen@mediatek.com>
To: <allen-kh.cheng@mediatek.com>
Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>,
<devicetree@vger.kernel.org>, <hsinyi@chromium.org>,
<krzysztof.kozlowski@canonical.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<robh+dt@kernel.org>, <ryder.lee@kernel.org>,
<wenst@chromium.org>
Subject: Re: [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT8186 dts and evaluation board and Makefile
Date: Wed, 27 Apr 2022 07:00:48 +0800 [thread overview]
Message-ID: <20220426230048.20685-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220426125046.17311-3-allen-kh.cheng@mediatek.com>
Hi Allen,
> Add basic chip support for Mediatek MT8186.
s/Mediatek/MediaTek/
>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
...snip...
> @@ -0,0 +1,232 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
I think we should use GPL-2.0-only OR BSD-2-Clause for newly added dts files.
i.e.,
// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +/*
> + * Copyright (C) 2022 MediaTek Inc.
> + */
> +/dts-v1/;
> +#include "mt8186.dtsi"
> +
> +/ {
..snip...
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> new file mode 100644
> index 000000000000..e8d8867412e3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> @@ -0,0 +1,932 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
I think we should use GPL-2.0-only OR BSD-2-Clause for newly added dts files.
i.e.,
// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +/*
> + * Copyright (C) 2022 MediaTek Inc.
> + * Author: Allen-KH Cheng <allenn-kh.cheng@mediatek.com>
> + */
> +/dts-v1/;
>
thanks,
Miles
prev parent reply other threads:[~2022-04-26 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:50 [PATCH v5 0/2] Add basic node support for Mediatek MT8186 SoC Allen-KH Cheng
2022-04-26 12:50 ` [PATCH v5 1/2] dt-bindings: arm: Add compatible for Mediatek MT8186 Allen-KH Cheng
2022-04-26 18:24 ` Rob Herring
2022-04-26 23:00 ` Miles Chen
2022-04-26 12:50 ` [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT8186 dts and evaluation board and Makefile Allen-KH Cheng
2022-04-26 23:00 ` Miles Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426230048.20685-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).