* [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
2022-04-26 10:18 [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
@ 2022-04-26 10:18 ` David Heidelberg
2022-04-26 10:34 ` Krzysztof Kozlowski
` (2 more replies)
2022-04-26 10:55 ` [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 Dmitry Baryshkov
` (2 subsequent siblings)
3 siblings, 3 replies; 8+ messages in thread
From: David Heidelberg @ 2022-04-26 10:18 UTC (permalink / raw)
To: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Jassi Brar,
Rob Herring, Krzysztof Kozlowski
Cc: David Heidelberg, Krzysztof Kozlowski, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, devicetree
These missing required properties are needed for
smp2p binding reference checks.
Also includes cosmetic change to the example formatting.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
v3:
- add Krzysztof R-b
---
.../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index c57dd423e98c..50f9aa72c670 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -76,9 +76,14 @@ examples:
smp2p-modem {
compatible = "qcom,smp2p";
- interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
- IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
- mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+ qcom,smem = <443>, <429>;
+ interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_SMP2P
+ IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_SMP2P>;
+ qcom,local-pid = <0>;
+ qcom,remote-pid = <2>;
/* Other SMP2P fields */
};
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
2022-04-26 10:18 ` [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
@ 2022-04-26 10:34 ` Krzysztof Kozlowski
2022-04-27 14:28 ` Manivannan Sadhasivam
2022-05-03 0:09 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-26 10:34 UTC (permalink / raw)
To: David Heidelberg, Manivannan Sadhasivam, Andy Gross,
Bjorn Andersson, Jassi Brar, Rob Herring, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Manivannan Sadhasivam, linux-arm-msm,
linux-kernel, devicetree
On 26/04/2022 12:18, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>
Missing reported-by:
Reported-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v3:
> - add Krzysztof R-b
BTW, this patch confuses me a bit... You sent it some time after I sent
a fix:
https://lore.kernel.org/all/20220402155551.16509-1-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
2022-04-26 10:18 ` [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
2022-04-26 10:34 ` Krzysztof Kozlowski
@ 2022-04-27 14:28 ` Manivannan Sadhasivam
2022-05-03 0:09 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2022-04-27 14:28 UTC (permalink / raw)
To: David Heidelberg
Cc: Andy Gross, Bjorn Andersson, Jassi Brar, Rob Herring,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, devicetree
On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> v3:
> - add Krzysztof R-b
> ---
> .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index c57dd423e98c..50f9aa72c670 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -76,9 +76,14 @@ examples:
>
> smp2p-modem {
> compatible = "qcom,smp2p";
> - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
> - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
> - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
> + qcom,smem = <443>, <429>;
> + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
> + IPCC_MPROC_SIGNAL_SMP2P
> + IRQ_TYPE_EDGE_RISING>;
> + mboxes = <&ipcc IPCC_CLIENT_LPASS
> + IPCC_MPROC_SIGNAL_SMP2P>;
>
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <2>;
> /* Other SMP2P fields */
> };
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
2022-04-26 10:18 ` [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
2022-04-26 10:34 ` Krzysztof Kozlowski
2022-04-27 14:28 ` Manivannan Sadhasivam
@ 2022-05-03 0:09 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-03 0:09 UTC (permalink / raw)
To: David Heidelberg
Cc: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Jassi Brar,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, devicetree
On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v3:
> - add Krzysztof R-b
> ---
> .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
2022-04-26 10:18 [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
2022-04-26 10:18 ` [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
@ 2022-04-26 10:55 ` Dmitry Baryshkov
2022-04-27 14:27 ` Manivannan Sadhasivam
2022-05-03 0:08 ` Rob Herring
3 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2022-04-26 10:55 UTC (permalink / raw)
To: David Heidelberg
Cc: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Jassi Brar,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
linux-arm-msm, linux-kernel, devicetree
On Tue, 26 Apr 2022 at 13:34, David Heidelberg <david@ixit.cz> wrote:
>
> Fill missing compatible already used in SM8450 DTS.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index 866efb278813..c57dd423e98c 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -27,6 +27,7 @@ properties:
> - qcom,sm6350-ipcc
> - qcom,sm8250-ipcc
> - qcom,sm8350-ipcc
> + - qcom,sm8450-ipcc
> - qcom,sc7280-ipcc
> - const: qcom,ipcc
>
> --
> 2.35.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
2022-04-26 10:18 [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
2022-04-26 10:18 ` [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
2022-04-26 10:55 ` [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 Dmitry Baryshkov
@ 2022-04-27 14:27 ` Manivannan Sadhasivam
2022-05-03 0:08 ` Rob Herring
3 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2022-04-27 14:27 UTC (permalink / raw)
To: David Heidelberg
Cc: Andy Gross, Bjorn Andersson, Jassi Brar, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, linux-arm-msm,
linux-kernel, devicetree
On Tue, Apr 26, 2022 at 12:18:36PM +0200, David Heidelberg wrote:
> Fill missing compatible already used in SM8450 DTS.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index 866efb278813..c57dd423e98c 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -27,6 +27,7 @@ properties:
> - qcom,sm6350-ipcc
> - qcom,sm8250-ipcc
> - qcom,sm8350-ipcc
> + - qcom,sm8450-ipcc
> - qcom,sc7280-ipcc
> - const: qcom,ipcc
>
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
2022-04-26 10:18 [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
` (2 preceding siblings ...)
2022-04-27 14:27 ` Manivannan Sadhasivam
@ 2022-05-03 0:08 ` Rob Herring
3 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-03 0:08 UTC (permalink / raw)
To: David Heidelberg
Cc: devicetree, Rob Herring, Manivannan Sadhasivam, linux-kernel,
Andy Gross, linux-arm-msm, Manivannan Sadhasivam, Jassi Brar,
Bjorn Andersson, Krzysztof Kozlowski
On Tue, 26 Apr 2022 12:18:36 +0200, David Heidelberg wrote:
> Fill missing compatible already used in SM8450 DTS.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread