From: Manivannan Sadhasivam <mani@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example
Date: Wed, 27 Apr 2022 19:58:37 +0530 [thread overview]
Message-ID: <20220427142837.GC4161@thinkpad> (raw)
In-Reply-To: <20220426101837.16201-2-david@ixit.cz>
On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Also includes cosmetic change to the example formatting.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> v3:
> - add Krzysztof R-b
> ---
> .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index c57dd423e98c..50f9aa72c670 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -76,9 +76,14 @@ examples:
>
> smp2p-modem {
> compatible = "qcom,smp2p";
> - interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
> - IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
> - mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
> + qcom,smem = <443>, <429>;
> + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
> + IPCC_MPROC_SIGNAL_SMP2P
> + IRQ_TYPE_EDGE_RISING>;
> + mboxes = <&ipcc IPCC_CLIENT_LPASS
> + IPCC_MPROC_SIGNAL_SMP2P>;
>
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <2>;
> /* Other SMP2P fields */
> };
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-04-27 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 10:18 [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
2022-04-26 10:18 ` [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
2022-04-26 10:34 ` Krzysztof Kozlowski
2022-04-27 14:28 ` Manivannan Sadhasivam [this message]
2022-05-03 0:09 ` Rob Herring
2022-04-26 10:55 ` [PATCH v4 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 Dmitry Baryshkov
2022-04-27 14:27 ` Manivannan Sadhasivam
2022-05-03 0:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427142837.GC4161@thinkpad \
--to=mani@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).