From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
- <patches@opensource.cirrus.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: wlf,arizona: Add spi-max-frequency
Date: Wed, 27 Apr 2022 14:48:25 +0000 [thread overview]
Message-ID: <20220427144825.GD38351@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <d43d7e40-40d7-a89e-115f-04a305d7239b@linaro.org>
On Wed, Apr 27, 2022 at 03:49:51PM +0200, Krzysztof Kozlowski wrote:
> On 27/04/2022 14:58, Charles Keepax wrote:
> > On Wed, Apr 27, 2022 at 12:21:43PM +0000, Charles Keepax wrote:
> >> On Wed, Apr 27, 2022 at 08:51:02AM +0200, Krzysztof Kozlowski wrote:
> The Arizona schema has unevaluatedProperties: false, which means unknown
> properties will not be accepted. Neither Arizona schema nor other
> referenced schemas define spi-max-frequency, so when the schema is run,
> the property will be unevaluated, thus cause a warning.
>
> This is visible here at the bottom (with Rob's work-in-progress):
> https://lore.kernel.org/linux-devicetree/345716e9-5624-5ba0-09f0-46e9850c546c@linaro.org/T/#m4b5d7cfdf34dbd410003b2faae4d840113050c51
>
> Although I think that I did not fix it properly, because I missed
> 'controller-data', so instead this should be fixed with referencing
> spi-peripheral-props like here:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.17.y&id=f412fe11c1a9d815565f3918c56f3fd02167c734
>
Ah yes I forgot the unevaluatedProperties didn't work properly,
sorry was running things on my DTs here with SPI and they were
all passing but of course I don't have Rob's fix to make the
unevaluatedProperties actually work.
Probably yeah include the spi properties yaml is a better
solution as that covers all the properties that might get used.
Thanks,
Charles
prev parent reply other threads:[~2022-04-27 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 6:51 [PATCH] dt-bindings: mfd: wlf,arizona: Add spi-max-frequency Krzysztof Kozlowski
2022-04-27 12:21 ` Charles Keepax
2022-04-27 12:58 ` Charles Keepax
2022-04-27 13:49 ` Krzysztof Kozlowski
2022-04-27 14:48 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427144825.GD38351@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).