Re: [PATCH v4 2/8] dt-bindings: pci/qcom,pcie: resets are not defined for msm8996

[Bjorn Helgaas <helgaas@kernel.org>]

Unlike the other patches in this series, this subject line mentions a
problem (actually, I don't even know whether it's a *problem* or just
a statement of fact), but doesn't say what this patch does.

Based on the patch, I guess this does something like:

  Require resets except for MSM8996/APQ8096

I don't know whether you're changing the prefix convention for this
file, or just didn't look to see how it was done in the past, but it's
nice to have some consistency:

  $ git log --oneline Documentation/devicetree/bindings/pci/qcom,pcie.txt
  f52d2a0f0d32 dt-bindings: pci: qcom: Document PCIe bindings for SM8150 SoC
  dddb4efa5192 dt-bindings: pci: qcom: Document PCIe bindings for SM8450
  45a3ec891370 PCI: qcom: Add sc8180x compatible
  320e10986ef7 dt-bindings: PCI: update references to Designware schema
  9f7368ff1210 dt-bindings: pci: qcom: Document PCIe bindings for IPQ6018 SoC
  c9f04600026f dt-bindings: PCI: qcom: Document ddrss_sf_tbu clock for sm8250
  458168247ccc dt-bindings: pci: qcom: Document PCIe bindings for SM8250 SoC
  d511580ea9c2 dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
  b11b8cc161de dt-bindings: PCI: qcom: Add ext reset
  736ae5c91712 dt-bindings: PCI: qcom: Add missing clks
  5d28bee7c91e dt-bindings: PCI: qcom: Add support for SDM845 PCIe
  29a50257a9d6 dt-bindings: PCI: qcom: Add QCS404 to the binding
  f625b1ade245 PCI: qcom: Add missing supplies required for msm8996
  8baf0151cd4b dt-bindings: PCI: qcom: Add support for IPQ8074
  90d52d57ccac PCI: qcom: Add support for IPQ4019 PCIe controller
  d0491fc39bdd PCI: qcom: Add support for MSM8996 PCIe controller
  845d5ca26647 PCI: qcom: Document PCIe devicetree bindings

Including both "pci" and "pcie" in the prefix seems like overkill.

On Thu, Apr 28, 2022 at 02:41:07PM +0300, Dmitry Baryshkov wrote:
> On MSM8996/APQ8096 platforms the PCIe controller doesn't have any
> resets. So move the requirement stance under the corresponding if
> condition.

s/stance/stanza/

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../devicetree/bindings/pci/qcom,pcie.yaml         | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 16f765e96128..ce4f53cdaba0 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -114,8 +114,6 @@ required:
>    - interrupt-map
>    - clocks
>    - clock-names
> -  - resets
> -  - reset-names
>  
>  allOf:
>    - $ref: /schemas/pci/pci-bus.yaml#
> @@ -504,6 +502,18 @@ allOf:
>        required:
>          - power-domains
>  
> +  - if:
> +      not:
> +        properties:
> +          compatibles:
> +            contains:
> +              enum:
> +                - qcom,pcie-msm8996
> +    then:
> +      required:
> +        - resets
> +        - reset-names
> +
>  unevaluatedProperties: false
>  
>  examples:
> -- 
> 2.35.1
>