From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Michael Walle <michael@walle.cc>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<UNGLinuxDriver@microchip.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: lan966x: remove PHY reset support
Date: Thu, 28 Apr 2022 22:37:46 +0200 [thread overview]
Message-ID: <20220428203746.yqzgtwmeo2nmifjk@soft-dev3-1.localhost> (raw)
In-Reply-To: <20220428114049.1456382-1-michael@walle.cc>
The 04/28/2022 13:40, Michael Walle wrote:
>
> Remove the unneeded PHY reset node as well as the driver support for it.
>
> This was already discussed [1] and I expect Microchip to Ack on this
> removal. Since there is no user, no breakage is expected.
This looks good to me:
Acked-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> I'm not sure it this should go through net or net-next and if the patches
> should have a Fixes: tag or not. In upstream linux there was never any user
> of it, so there is no bug to be fixed. But OTOH if the schema fix isn't
> backported, then there might be an older schema version still containing
> the reset node. Thoughts?
>
> The patches needed for the GPIO part are just waiting to be picked up by
> Linus [2,3]. This patch and the GPIO parts are the last pieces of the
> puzzle to get ethernet working on the LAN9668 on upstream linux.
>
> [1] https://lore.kernel.org/netdev/20220330110210.3374165-1-michael@walle.cc/
> [2] https://lore.kernel.org/linux-gpio/CACRpkdbxmN+SWt95aGHjA2ZGnN61aWaA7c5S4PaG+WePAj=htg@mail.gmail.com/
> [3] https://lore.kernel.org/linux-gpio/20220420191926.3411830-1-michael@walle.cc/
>
> Michael Walle (2):
> dt-bindings: net: lan966x: remove PHY reset
> net: lan966x: remove PHY reset support
>
> .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 --
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 8 +-------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> --
> 2.30.2
>
--
/Horatiu
next prev parent reply other threads:[~2022-04-28 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:40 [PATCH net-next 0/2] net: lan966x: remove PHY reset support Michael Walle
2022-04-28 11:40 ` [PATCH net-next 1/2] dt-bindings: net: lan966x: remove PHY reset Michael Walle
2022-05-03 13:04 ` Rob Herring
2022-05-03 13:22 ` Michael Walle
2022-04-28 11:40 ` [PATCH net-next 2/2] net: lan966x: remove PHY reset support Michael Walle
2022-04-28 20:37 ` Horatiu Vultur [this message]
2022-04-29 12:45 ` [PATCH net-next 0/2] " Andrew Lunn
2022-04-30 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428203746.yqzgtwmeo2nmifjk@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).