From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kaushal Kumar <quic_kaushalk@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ARM: dts: qcom: sdx65-mtp: Enable QPIC NAND support
Date: Mon, 2 May 2022 20:26:51 +0530 [thread overview]
Message-ID: <20220502145651.GD98313@thinkpad> (raw)
In-Reply-To: <1651500878-10244-5-git-send-email-quic_kaushalk@quicinc.com>
On Mon, May 02, 2022 at 07:14:38AM -0700, Kaushal Kumar wrote:
> Enable QPIC NAND devicetree node for Qualcomm SDX65-MTP board.
>
> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com>
One comment below, with that fixed:
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 153ad2a..b0027c1 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -249,6 +249,21 @@
> status = "ok";
> };
>
> +&qpic_nand {
> + status = "ok";
> +
Status should be "okay".
Thanks,
Mani
> + nand@0 {
> + reg = <0>;
> +
> + nand-ecc-strength = <4>;
> + nand-ecc-step-size = <512>;
> + nand-bus-width = <8>;
> + /* ico and efs2 partitions are secured */
> + secure-regions = /bits/ 64 <0x500000 0x500000
> + 0xa00000 0xb00000>;
> + };
> +};
> +
> &usb {
> status = "okay";
> };
> --
> 2.7.4
>
prev parent reply other threads:[~2022-05-02 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 14:14 [PATCH v2 0/4] Add QPIC BAM and QPIC NAND devicetree support for SDX65 Kaushal Kumar
2022-05-02 14:14 ` [PATCH v2 1/4] ARM: dts: qcom: sdx65: Add QPIC BAM support Kaushal Kumar
2022-05-02 14:14 ` [PATCH v2 2/4] ARM: dts: qcom: sdx65: Add QPIC NAND support Kaushal Kumar
2022-05-02 14:14 ` [PATCH v2 3/4] ARM: dts: qcom: sdx65-mtp: Enable QPIC BAM support Kaushal Kumar
2022-05-02 14:57 ` Manivannan Sadhasivam
2022-05-02 14:14 ` [PATCH v2 4/4] ARM: dts: qcom: sdx65-mtp: Enable QPIC NAND support Kaushal Kumar
2022-05-02 14:56 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502145651.GD98313@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kaushalk@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).