From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1C8DC433EF for ; Tue, 3 May 2022 10:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231181AbiECKMU (ORCPT ); Tue, 3 May 2022 06:12:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233084AbiECKMT (ORCPT ); Tue, 3 May 2022 06:12:19 -0400 Received: from mx-out1.startmail.com (mx-out1.startmail.com [145.131.90.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D10535ABF; Tue, 3 May 2022 03:08:45 -0700 (PDT) Date: Tue, 3 May 2022 05:08:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com; s=2020-07; t=1651572524; bh=hVp7E/4O2QMrdbBVhjD1hXUYmGcMno8QOmZcxB9vkjM=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:From:Subject:To:Date: Sender:Content-Type:Content-Transfer-Encoding:Content-Disposition: Mime-Version:Reply-To:In-Reply-To:References:Message-Id:Autocrypt; b=BKu3IyLhQ6IwIyD9OPTGKdemLnjlkEPlDkHHLXrlVTW2eUPK30dDyM9JnRX2eUCi7 Kyh0HzAjpoNpJcNVTgb+iFE7ybjDB2jj/SsTrzLGvQN2TOL3/wHrEfN8WD1711tUmI rOnwGiZ5sawajs6Tg154SVq3Uai+YKrEbdAc8DARGiglmSGoPuSnMB98GGSMi3QUmb W/EOhuTfNicdke6bsLFl0us0mGJAcZbWZXTyVXQM94vkQN8KXka44SO6Swj8mNU4aP zUgN/4k9RQnFwV9ZbzSdHe3zHCtRDAOBiF8JAy43+B6eSMs7vb9IyYcgYiB8QH+prU 10fIE6fYhifBQ== From: "Marty E. Plummer" To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] clk: hisilicon: add CRG driver Hi3521a SoC Message-ID: <20220503100839.dyujyttv34t5equz@proprietary-killer> References: <20220501051020.2432338-1-hanetzer@startmail.com> <20220501051020.2432338-2-hanetzer@startmail.com> <0b66148a-c65f-2acf-9751-ae931778ad45@linaro.org> <20220501113215.rh6he5344hssziy7@proprietary-killer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 03, 2022 at 11:41:49AM +0200, Krzysztof Kozlowski wrote: > On 01/05/2022 13:36, Marty E. Plummer wrote: > > On Sun, May 01, 2022 at 10:35:37AM +0200, Krzysztof Kozlowski wrote: > >> On 01/05/2022 07:10, Marty E. Plummer wrote: > >>> Add CRG driver for Hi3521A SoC. CRG (Clock and Reset Generator) module > >>> generates clock and reset signals used by other module blocks on SoC. > >>> > >>> > >> (...) > >> > >>> + return; > >>> + > >>> + hisi_clk_register_mux(hi3521a_sysctrl_mux_clks, > >>> + ARRAY_SIZE(hi3521a_sysctrl_mux_clks), > >>> + clk_data); > >>> +} > >>> +CLK_OF_DECLARE(hi3521a_sysctrl, "hisilicon,hi3521a-sysctrl", hi3521a_sysctrl_init); > >> Missing bindings. > >> > > Assume you mean the Documentation/dt/binding/... file? Will do. I > > probably should have prefixed it with RFC, as I'm mostly hoping to get > > the attention of the hisi people to see what's the deal with the mtd > > reads being borked. > > Then just don't Cc devicetree folks and put in cover letter disclaimer > that this was intentionally omitted and will be later fixed. > Yes, I should have disclaimered it, but I didn't intentionally cc dt folks, just what getmaintainer popped out. > It is a waste of time of reviewers to look/filter/organize such email, > if it is intentionally not for us. > > Best regards, > Krzysztof