From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_tdas@quicinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings
Date: Tue, 03 May 2022 12:19:01 -0700 [thread overview]
Message-ID: <20220503191903.CEBE0C385A9@smtp.kernel.org> (raw)
In-Reply-To: <YmrnMQwIR9wOeoKE@ripper>
Quoting Bjorn Andersson (2022-04-28 12:12:49)
> On Thu 28 Apr 09:24 PDT 2022, Dmitry Baryshkov wrote:
>
> > > >
> > > > And actually might I suggest an alternative approach to manually using
> > > > indices everywhere? What about spending the time once during the boot to
> > > > convert .fw_name and clock_names to parent indices during clock registration
> > > > and then using them for all the further operations?
> > > >
> > >
> > > I'm pretty sure that's what clk_core_fill_parent_index() already does.
> >
> > In this case I think we should go for clock-name in the DT and
> > auto-flled indices inside. Stephen, WDYT? Would that fix your concern
> > for comparing strings each and every time?
> >
>
> You mean, just continue doing what we've been doing lately with fw_name
> etc?
>
> That lookup is the one that Stephen wants to avoid.
>
Right. Translating .fw_name to indices isn't a solution because I want to
1. Reduce the number of string comparisons
2. Shrink the kernel's data section by removing strings
and having there still be strings works against both points.
prev parent reply other threads:[~2022-05-03 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 23:00 [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings Bjorn Andersson
2022-04-22 23:00 ` [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver Bjorn Andersson
2022-04-23 1:53 ` Stephen Boyd
2022-04-23 1:48 ` [PATCH v2 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings Stephen Boyd
2022-04-23 3:02 ` Bjorn Andersson
2022-04-23 3:13 ` Stephen Boyd
2022-04-23 3:43 ` Bjorn Andersson
2022-04-25 22:34 ` Stephen Boyd
2022-04-28 15:44 ` Dmitry Baryshkov
2022-04-28 16:01 ` Bjorn Andersson
2022-04-28 16:24 ` Dmitry Baryshkov
2022-04-28 19:12 ` Bjorn Andersson
2022-05-03 19:19 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503191903.CEBE0C385A9@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).