From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D29FC433EF for ; Wed, 4 May 2022 18:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376272AbiEDSJ1 (ORCPT ); Wed, 4 May 2022 14:09:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376718AbiEDSIt (ORCPT ); Wed, 4 May 2022 14:08:49 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6354072E17; Wed, 4 May 2022 10:24:20 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id D5E261C0BBB; Wed, 4 May 2022 19:24:18 +0200 (CEST) Date: Wed, 4 May 2022 19:24:17 +0200 From: Pavel Machek To: Andy Shevchenko Cc: Markuss Broks , Linux Kernel Mailing List , phone-devel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Hans de Goede , Andy Shevchenko ," <~postmarketos/upstreaming@lists.sr.ht>, Rob Herring , Christophe JAILLET , Linus Walleij , Linux LED Subsystem , devicetree Subject: Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional Message-ID: <20220504172417.GE1623@bug> References: <20220408184104.13665-1-markuss.broks@gmail.com> <20220408184104.13665-3-markuss.broks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi! > > Make the AUX pin optional, since it isn't a core part of functionality, > > and the device is designed to be operational with only one CTRL pin. > > > > Also pick up maintenance for the LED driver and the yaml bindings. > > It's polite to Cc reviewers of your previous versions of the series. > > While this patch is fine to me, Reviewed-by: Andy Shevchenko > one comment below. Thanks for review. Markuss, can you collect review tags and post v7?. Please drop MAINTAINERS part for now. And sorry for delays. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html