From: Jonathan Cameron <jic23@kernel.org>
To: Dmitry Rokosov <DDRokosov@sberdevices.ru>
Cc: Rob Herring <robh@kernel.org>,
"stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"stephan@gerhold.net" <stephan@gerhold.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] dt-bindings: iio: accel: add dt-binding schema for msa311 accel driver
Date: Wed, 4 May 2022 21:48:40 +0100 [thread overview]
Message-ID: <20220504214840.1ad32bff@jic23-huawei> (raw)
In-Reply-To: <20220504183716.shhpi5adcxz4ufvj@CAB-WSD-L081021.sigma.sbrf.ru>
On Wed, 4 May 2022 18:36:33 +0000
Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:
> Hello Rob,
>
> I've missed one note below, please check if possible.
>
> On Tue, Apr 26, 2022 at 03:31:05PM -0500, Rob Herring wrote:
> > On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote:
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 0
> >
> > These apply to 'reg' in a child node, but you don't have child nodes so
> > drop them.
> >
>
> I'm afraid, I made a mistake in the previous reply. Here I applied
> address-cells and size-cells to show which type accelerometer's reg
> property has, like this one:
>
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> accelerometer@62 {
> compatible = "memsensing,msa311";
> reg = <0x62>;
>
> Above accelerometer@62 is child node for i2c bus node, so address and
> size cells mean accelerometer reg format. Am I missing something?
They are characteristics of the i2c master and hence
are listed in those binding docs, not the one for the accelerometer.
Thanks,
Jonathan
>
prev parent reply other threads:[~2022-05-04 20:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 15:45 [PATCH v1 0/3] iio: accel: add MSA311 accelerometer driver Rokosov Dmitry Dmitrievich
2022-04-19 15:45 ` [PATCH v1 1/3] dt-bindings: vendor-prefixes: add MEMSensing Microsystems Co., Ltd Rokosov Dmitry Dmitrievich
2022-04-26 20:28 ` Rob Herring
2022-04-27 9:01 ` Dmitry Rokosov
2022-04-19 15:45 ` [PATCH v1 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver Rokosov Dmitry Dmitrievich
2022-04-20 10:50 ` Jonathan Cameron
2022-04-26 17:23 ` Dmitry Rokosov
2022-04-28 19:41 ` Jonathan Cameron
2022-05-18 12:25 ` Dmitry Rokosov
2022-05-22 10:36 ` Jonathan Cameron
2022-05-25 17:53 ` Dmitry Rokosov
2022-04-20 10:54 ` Jonathan Cameron
2022-04-21 14:07 ` Dmitry Rokosov
2022-04-19 15:45 ` [PATCH v1 3/3] dt-bindings: iio: accel: add dt-binding schema for msa311 accel driver Rokosov Dmitry Dmitrievich
2022-04-20 8:51 ` Jonathan Cameron
2022-04-21 13:55 ` Dmitry Rokosov
2022-04-26 20:31 ` Rob Herring
2022-04-27 8:58 ` Dmitry Rokosov
2022-05-04 18:36 ` Dmitry Rokosov
2022-05-04 20:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504214840.1ad32bff@jic23-huawei \
--to=jic23@kernel.org \
--cc=DDRokosov@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@sberdevices.ru \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stano.jakubek@gmail.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).