From: Vladimir Oltean <olteanv@gmail.com>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 08/12] net: dsa: rzn1-a5psw: add FDB support
Date: Thu, 5 May 2022 19:30:33 +0300 [thread overview]
Message-ID: <20220505163033.3n744lm2ipsjmrlt@skbuf> (raw)
In-Reply-To: <20220505154431.06174a04@fixe.home>
On Thu, May 05, 2022 at 03:44:31PM +0200, Clément Léger wrote:
> Indeed, I'll simply remove these error message. Should I still return
> an error value however ? Seems like I should not to avoid triggering
> any error that might confuse the user.
The error code will not be propagated to the bridge driver anyway, but
will trigger prints in dsa_slave_switchdev_event_work() however.
You have to choose between 2 alternatives
(a) keep the FDB entry around until it gets removed from all VLANs
(b) delete the FDB entry as soon as it gets removed from the first VLAN
Both options are going to raise eyebrows. (a) will result in "huh, why
did my packet get delivered to this port when the address wasn't in the
FDB?", while (b) will result in "huh, why was my packet flooded when the
address was in the FDB?"
And since (b) is of lower complexity than (a), I'd just silently exit,
maybe add a comment explaining why, and hope for the best.
next prev parent reply other threads:[~2022-05-05 16:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 9:29 [PATCH net-next v3 00/12] add support for Renesas RZ/N1 ethernet subsystem devices Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 01/12] net: dsa: add support for ethtool get_rmon_stats() Clément Léger
2022-05-04 15:50 ` Vladimir Oltean
2022-05-04 9:29 ` [PATCH net-next v3 02/12] net: dsa: add Renesas RZ/N1 switch tag driver Clément Léger
2022-05-04 16:00 ` Vladimir Oltean
2022-05-05 13:48 ` Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 03/12] dt-bindings: net: pcs: add bindings for Renesas RZ/N1 MII converter Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 04/12] net: pcs: add Renesas MII converter driver Clément Léger
2022-05-05 7:16 ` Geert Uytterhoeven
2022-05-05 12:32 ` Clément Léger
2022-05-05 13:00 ` Geert Uytterhoeven
2022-05-05 13:03 ` Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 06/12] net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver Clément Léger
2022-05-04 16:14 ` Vladimir Oltean
2022-05-05 12:59 ` Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 07/12] net: dsa: rzn1-a5psw: add statistics support Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 08/12] net: dsa: rzn1-a5psw: add FDB support Clément Léger
2022-05-04 16:24 ` Vladimir Oltean
2022-05-05 13:44 ` Clément Léger
2022-05-05 16:30 ` Vladimir Oltean [this message]
2022-05-04 9:29 ` [PATCH net-next v3 09/12] ARM: dts: r9a06g032: describe MII converter Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 10/12] ARM: dts: r9a06g032: describe GMAC2 Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 11/12] ARM: dts: r9a06g032: describe switch Clément Léger
2022-05-04 9:30 ` [PATCH net-next v3 12/12] MAINTAINERS: add Renesas RZ/N1 switch related driver entry Clément Léger
2022-05-05 7:29 ` [PATCH net-next v3 00/12] add support for Renesas RZ/N1 ethernet subsystem devices Geert Uytterhoeven
2022-05-05 9:48 ` Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505163033.3n744lm2ipsjmrlt@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=jimmy.lalande@se.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).