From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ARM: dts: qcom: sdx65-mtp: Enable USB3 and PHY support
Date: Fri, 6 May 2022 12:35:31 +0530 [thread overview]
Message-ID: <20220506070531.GE17659@thinkpad> (raw)
In-Reply-To: <1651482395-29443-5-git-send-email-quic_rohiagar@quicinc.com>
On Mon, May 02, 2022 at 02:36:35PM +0530, Rohit Agarwal wrote:
> Enable the support for USB3 controller, QMP PHY and HS PHY on SDX65 MTP.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
I hope you have tested the interface using a gadget driver.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 29 +++++++++++++++++++++++++----
> 1 file changed, 25 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 79dc31a..6920524 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -123,7 +123,7 @@
> regulator-max-microvolt = <1300000>;
> };
>
> - ldo1 {
> + vreg_l1b_1p2: ldo1 {
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> @@ -141,13 +141,13 @@
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> - ldo4 {
> + vreg_l4b_0p88: ldo4 {
> regulator-min-microvolt = <880000>;
> regulator-max-microvolt = <912000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> - ldo5 {
> + vreg_l5b_1p8: ldo5 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> @@ -177,7 +177,7 @@
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> - ldo10 {
> + vreg_l10b_3p08: ldo10 {
> regulator-min-microvolt = <3088000>;
> regulator-max-microvolt = <3088000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> @@ -244,3 +244,24 @@
> };
> };
> };
> +
> +&usb {
> + status = "okay";
> +};
> +
> +&usb_dwc3 {
> + dr_mode = "peripheral";
> +};
> +
> +&usb_hsphy {
> + status = "okay";
> + vdda-pll-supply = <&vreg_l4b_0p88>;
> + vdda33-supply = <&vreg_l10b_3p08>;
> + vdda18-supply = <&vreg_l5b_1p8>;
> +};
> +
> +&usb_qmpphy {
> + status = "okay";
> + vdda-phy-supply = <&vreg_l4b_0p88>;
> + vdda-pll-supply = <&vreg_l1b_1p2>;
> +};
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-05-06 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 9:06 [PATCH v2 0/4] Devicetree updates for Interconnect, USB3 and PHY support Rohit Agarwal
2022-05-02 9:06 ` [PATCH v2 1/4] ARM: dts: qcom: sdx65: Add interconnect nodes Rohit Agarwal
2022-05-03 11:51 ` Krzysztof Kozlowski
2022-05-06 7:02 ` Manivannan Sadhasivam
2022-05-02 9:06 ` [PATCH v2 2/4] dt-bindings: usb: qcom,dwc3: Add binding for SDX65 Rohit Agarwal
2022-05-03 11:52 ` Krzysztof Kozlowski
2022-05-06 7:02 ` Manivannan Sadhasivam
2022-05-02 9:06 ` [PATCH v2 3/4] ARM: dts: qcom: sdx65: Add USB3 and PHY support Rohit Agarwal
2022-05-05 20:02 ` Greg KH
2022-05-06 6:55 ` Manivannan Sadhasivam
2022-05-06 7:03 ` Manivannan Sadhasivam
2022-05-02 9:06 ` [PATCH v2 4/4] ARM: dts: qcom: sdx65-mtp: Enable " Rohit Agarwal
2022-05-06 7:05 ` Manivannan Sadhasivam [this message]
2022-06-28 20:19 ` (subset) [PATCH v2 0/4] Devicetree updates for Interconnect, " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506070531.GE17659@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).