From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A19AC433EF for ; Fri, 6 May 2022 07:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243019AbiEFHa3 (ORCPT ); Fri, 6 May 2022 03:30:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240161AbiEFHa2 (ORCPT ); Fri, 6 May 2022 03:30:28 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E67AD5C351 for ; Fri, 6 May 2022 00:26:45 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nms6h-0003k7-Em; Fri, 06 May 2022 09:10:31 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nms6e-0001g4-87; Fri, 06 May 2022 09:10:28 +0200 Date: Fri, 6 May 2022 09:10:28 +0200 From: Sascha Hauer To: Heiko =?iso-8859-15?Q?St=FCbner?= Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Rob Herring Subject: Re: [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Message-ID: <20220506071028.GS4012@pengutronix.de> References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <1911394.usQuhbGJ8B@diego> <20220505064131.GF4012@pengutronix.de> <2508329.Lt9SDvczpP@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2508329.Lt9SDvczpP@diego> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:06:01 up 36 days, 19:35, 74 users, load average: 0.40, 0.33, 0.26 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 05, 2022 at 09:23:03AM +0200, Heiko Stübner wrote: > Am Donnerstag, 5. Mai 2022, 08:41:31 CEST schrieb Sascha Hauer: > > On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote: > > > Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer: > > > > The VOP2 is the display output controller on the RK3568. Add the node > > > > for it to the dtsi file along with the required display-subsystem node > > > > and the iommu node. > > > > > > > > Signed-off-by: Sascha Hauer > > > > Acked-by: Rob Herring > > > > --- > > > > + vop: vop@fe040000 { > > > > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > > > > + reg-names = "regs", "gamma_lut"; > > > > > > reg-names does not seem to be part of the dt-binding. > > > Though now in the vop2-driver I see that the code uses that naming. > > > > > > I guess we might want to just go the vop1-way by using numbered > > > platform-resources via a follow-up patch and drop the regnames here? > > > > Or we could document the reg-names properties in a follow-up patch. > > Wouldn't that be better? > > Also a possibility. Although that of course leads us into the naming > bike-shed ;-) ... i.e. for reg-names I'd do "vop" + "gamme-lut" (dash instead > of underscore) - instead of the ones used right now. I also like dashes better than underscores and "vop" describes it better than the generic "reg" name, so at least the two of us don't need to dive deeper into the naming bike-shed ;) > > While using numbered resources would keep the commonality between > both vops I like the named resources better, but I'll leave it up to you. You decide, I'll create fixup patches in either direction. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |