devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miles Chen <miles.chen@mediatek.com>
To: <robh@kernel.org>
Cc: <allen-kh.cheng@mediatek.com>,
	<angelogioacchino.delregno@collabora.com>,
	<chun-jie.chen@mediatek.com>, <devicetree@vger.kernel.org>,
	<ikjn@chromium.org>, <krzk+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
	<matthias.bgg@kernel.org>, <miles.chen@mediatek.com>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock
Date: Tue, 10 May 2022 07:18:08 +0800	[thread overview]
Message-ID: <20220509231808.7657-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <YnmXX0DldjhmbjY3@robh.at.kernel.org>

Hi Rob,

>On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
>> Hi Rob,
>> 
>> >> From: Matthias Brugger <matthias.bgg@gmail.com>
>> >> 
>> >> The msdc gate is part of the MMC driver. Delete the binding description
>> >> of this node.
>> > 
>> >An ABI break is okay because ...?
>> 
>> Sorry for that, 
>> 
>> If the mediatek,mt8192-msdc part is removed from the driver, 
>
>That's an ABI break too. You just need to explain why as Matthias did in 
>the commit message if the ABI break is okay.

Thanks for your explanation.

I would like to learn more about this. In this case
If there was a user (say xxx.c) but the user was removed, can I remove mediatek,mt8192-msdc?

thanks,
Miles

>
>> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or 
>> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.
>
>We do that sometimes, but depends on the situation.
>
>Rob


  reply	other threads:[~2022-05-09 23:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 12:31 [PATCH v2 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate") matthias.bgg
2022-04-29 12:31 ` [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock matthias.bgg
2022-04-29 13:31   ` AngeloGioacchino Del Regno
2022-04-30 23:14   ` Miles Chen
2022-05-03 21:48   ` Rob Herring
2022-05-05  5:31     ` [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock Miles Chen
2022-05-09 22:36       ` Rob Herring
2022-05-09 23:18         ` Miles Chen [this message]
2022-05-05 16:47     ` [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock Matthias Brugger
2022-05-20 22:21       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509231808.7657-1-miles.chen@mediatek.com \
    --to=miles.chen@mediatek.com \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chun-jie.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ikjn@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=matthias.bgg@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).