From: Stephen Boyd <swboyd@chromium.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
chrome-platform@lists.linux.dev,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Craig Hesling <hesling@chromium.org>,
Tom Hughes <tomhughes@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Benson Leung <bleung@chromium.org>,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v5 2/3] dt-bindings: cros-ec: Reorganize property availability
Date: Wed, 11 May 2022 18:39:20 -0700 [thread overview]
Message-ID: <20220512013921.164637-3-swboyd@chromium.org> (raw)
In-Reply-To: <20220512013921.164637-1-swboyd@chromium.org>
Various properties in the cros-ec binding only apply to different
compatible strings. For example, the interrupts and reg property are
required for all cros-ec devices except for the rpmsg version. Add some
conditions to update the availability of properties so that they can't
be used with compatibles that don't support them.
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>
Cc: <chrome-platform@lists.linux.dev>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Craig Hesling <hesling@chromium.org>
Cc: Tom Hughes <tomhughes@chromium.org>
Cc: Alexandru M Stan <amstan@chromium.org>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Benson Leung <bleung@chromium.org>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
.../bindings/mfd/google,cros-ec.yaml | 39 +++++++++++++------
1 file changed, 27 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 99eda9ab0651..409ecef967ce 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -148,18 +148,33 @@ patternProperties:
required:
- compatible
-if:
- properties:
- compatible:
- contains:
- enum:
- - google,cros-ec-i2c
- - google,cros-ec-rpmsg
-then:
- properties:
- google,cros-ec-spi-pre-delay: false
- google,cros-ec-spi-msg-delay: false
- spi-max-frequency: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ not:
+ contains:
+ const: google,cros-ec-spi
+ then:
+ properties:
+ controller-data: false
+ google,cros-ec-spi-pre-delay: false
+ google,cros-ec-spi-msg-delay: false
+ spi-max-frequency: false
+
+ - if:
+ properties:
+ compatible:
+ not:
+ contains:
+ const: google,cros-ec-rpmsg
+ then:
+ properties:
+ mediatek,rpmsg-name: false
+
+ required:
+ - reg
+ - interrupts
additionalProperties: false
--
https://chromeos.dev
next prev parent reply other threads:[~2022-05-12 1:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 1:39 [PATCH v5 0/3] dt-bindings: cros-ec: Update for fingerprint devices Stephen Boyd
2022-05-12 1:39 ` [PATCH v5 1/3] dt-bindings: cros-ec: Fix a typo in description Stephen Boyd
2022-05-12 15:20 ` Guenter Roeck
2022-05-16 15:15 ` Rob Herring
2022-05-23 15:11 ` Lee Jones
2022-05-12 1:39 ` Stephen Boyd [this message]
2022-05-12 23:44 ` [PATCH v5 2/3] dt-bindings: cros-ec: Reorganize property availability Doug Anderson
2022-05-16 19:32 ` Stephen Boyd
2022-05-16 15:20 ` Rob Herring
2022-05-12 1:39 ` [PATCH v5 3/3] dt-bindings: cros-ec: Add ChromeOS fingerprint binding Stephen Boyd
2022-05-12 23:44 ` Doug Anderson
2022-05-16 15:20 ` Rob Herring
2022-05-16 19:23 ` Stephen Boyd
2022-05-18 16:13 ` Rob Herring
2022-05-18 19:56 ` Stephen Boyd
2022-05-19 19:48 ` Rob Herring
2022-06-06 3:33 ` [PATCH v5 0/3] dt-bindings: cros-ec: Update for fingerprint devices patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512013921.164637-3-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=hesling@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=tomhughes@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).