From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6678C433F5 for ; Fri, 13 May 2022 17:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383122AbiEMRkY (ORCPT ); Fri, 13 May 2022 13:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383115AbiEMRkW (ORCPT ); Fri, 13 May 2022 13:40:22 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CEC53703E for ; Fri, 13 May 2022 10:40:21 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id a191so8151810pge.2 for ; Fri, 13 May 2022 10:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ww/qFjWwrZ3PoYuCt3E6efWcKpC5tEXZBrJvZ8cR1LI=; b=O93qK4w/S03z5gd4Z+CP5yG9MFg/tvmoc9kyyCQqcV/Mz2YexNCrZo01E2mtLKBtxR TRkAlkWmi6D9g3qdIzer7hfnNqJj2J3f4FljvBmblziDyWfSxhbe/vKfL1AGgTuUTsKr DoWTcCkB9v6g+skYiRdCfCo3rbG2J6gdkmU3bmnAh3vq1mscALwOR24Gisf+2WZJxLKE 8uNwQeg9/6kOmzB5byZmOYqLib0M+Y0lvl1FKEpi7xjYOm4zxe+J52sJOtAJy30DiobH 8xcYSXp/WP6NWt85a5xY4DktYxvQ7eMPBZPMGHG3qn+uit9yW3UN2bZmVArwGTQ88de9 dxlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ww/qFjWwrZ3PoYuCt3E6efWcKpC5tEXZBrJvZ8cR1LI=; b=EH7sbFdnUI1C2/0R8D+XdoQhxGLsEnm1tvAv54+mAZ0V1GR5BrucUIyGp6CyfWRZwH qKglKVyOoeWNVZwOoB4/8cFIXzE4P6NaccS5xG9fkDuQ4Dg+LjmheV9+7xQzoBXkZGIQ H/gMScvYGtZwkIVnz7dkaKtW61uNkqw3l4WEwxdhurxckdQUVoHdYMDWccwH+XwYXC60 nQRZdToZoVPboW8XJRzjhAQChFi2Fx8Z6ePsPFBeblJuwLfABvQx33hxpOzA/7O7+U+O BBAJyyvwG9Z1E4cH19vdUauKLSlHK8zITdyVsywT6LxHEDPTFPJllX0Ni+zzLTYBiCCr bGwQ== X-Gm-Message-State: AOAM533/tbBZYXEJ3xzEKU9tRj+fq852aU/XBKjdB8UtsO6IXDebxVIQ mn4ab2Jm+2nh5q8OLPdIIhcp X-Google-Smtp-Source: ABdhPJzraGPi1ax/y/zer2RyzKcWfeu62crVSXxE94AtGdfKOMGGkKDp4NJOyHwJem3eCBrEO733Rw== X-Received: by 2002:a05:6a00:a85:b0:506:b9e:7f43 with SMTP id b5-20020a056a000a8500b005060b9e7f43mr5524669pfl.5.1652463620335; Fri, 13 May 2022 10:40:20 -0700 (PDT) Received: from thinkpad ([117.202.184.246]) by smtp.gmail.com with ESMTPSA id j18-20020a170902da9200b0015e8d4eb272sm2160673plx.188.2022.05.13.10.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 10:40:19 -0700 (PDT) Date: Fri, 13 May 2022 23:10:10 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , "Rafael J. Wysocki" , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, Rob Herring Subject: Re: [PATCH v3 3/7] dt-bindings: ufs: common: add OPP table Message-ID: <20220513174010.GC1922@thinkpad> References: <20220513061347.46480-1-krzysztof.kozlowski@linaro.org> <20220513061347.46480-4-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220513061347.46480-4-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, May 13, 2022 at 08:13:43AM +0200, Krzysztof Kozlowski wrote: > Except scaling UFS and bus clocks, it's necessary to scale also the > voltages of regulators or power domain performance state levels. Adding > Operating Performance Points table allows to adjust power domain > performance state, depending on the UFS clock speed. > > OPPv2 deprecates previous property limited to clock scaling: > freq-table-hz. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Rob Herring > > --- > > Cc: Manivannan Sadhasivam > --- > .../devicetree/bindings/ufs/ufs-common.yaml | 34 +++++++++++++++++-- > 1 file changed, 31 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > index 47a4e9e1a775..d7d2c8a136bb 100644 > --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml > +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > @@ -20,11 +20,24 @@ properties: > items: > - description: Minimum frequency for given clock in Hz > - description: Maximum frequency for given clock in Hz > + deprecated: true > description: | > + Preferred is operating-points-v2. > + > Array of operating frequencies in Hz stored in the same order > - as the clocks property. If this property is not defined or a value in the > - array is "0" then it is assumed that the frequency is set by the parent > - clock or a fixed rate clock source. > + as the clocks property. If either this property or operating-points-v2 is > + not defined or a value in the array is "0" then it is assumed that the > + frequency is set by the parent clock or a fixed rate clock source. > + > + operating-points-v2: > + description: > + Preferred over freq-table-hz. > + If present, each OPP must contain array of frequencies stored in the same > + order for each clock. If clock frequency in the array is "0" then it is > + assumed that the frequency is set by the parent clock or a fixed rate > + clock source. This description mentions only the clocks and not voltages. But in theory, the OPP table can contain other parameters like current, bandwidth, etc,... So to avoid confusion, I'd suggest to get rid of the description. > + > + opp-table: true > > interrupts: > maxItems: 1 > @@ -75,8 +88,23 @@ properties: > > dependencies: > freq-table-hz: [ 'clocks' ] > + operating-points-v2: [ 'clocks', 'clock-names' ] What about voltage regulators if relevant opp property is present? Thanks, Mani > > required: > - interrupts > > +allOf: > + - if: > + required: > + - freq-table-hz > + then: > + properties: > + operating-points-v2: false > + - if: > + required: > + - operating-points-v2 > + then: > + properties: > + freq-table-hz: false > + > additionalProperties: true > -- > 2.32.0 > -- மணிவண்ணன் சதாசிவம்