From: Jonathan Cameron <jic23@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Shreeya Patel <shreeya.patel@collabora.com>,
lars@metafoo.de, robh+dt@kernel.org, Zhigang.Shi@liteon.com,
krisman@collabora.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, alvaro.soliverez@collabora.com
Subject: Re: [PATCH v4 3/3] iio: light: Add support for ltrf216a sensor
Date: Sat, 14 May 2022 17:17:38 +0100 [thread overview]
Message-ID: <20220514171738.062b127d@jic23-huawei> (raw)
In-Reply-To: <57bfc915-c761-3ba4-93d0-776f9b5f93b3@gmail.com>
On Fri, 13 May 2022 02:40:41 +0300
Dmitry Osipenko <digetx@gmail.com> wrote:
> Hello Shreeya,
>
> ...
> > +#include <linux/init.h>
> > +#include <linux/mod_devicetable.h>
>
> You may safely remove these includes because module.h always provides them.
Safely yes, but generally I'd prefer direct include
of mod_devicetable.h because of the direct use of
elements from it in the driver.
Jonathan
next prev parent reply other threads:[~2022-05-14 16:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 9:40 [PATCH v4 0/3] Add LTRF216A Driver Shreeya Patel
2022-05-11 9:40 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add 'ltr' as deprecated vendor prefix Shreeya Patel
2022-05-16 17:00 ` Rob Herring
2022-05-17 10:37 ` Shreeya Patel
2022-05-18 16:32 ` Rob Herring
2022-05-23 14:57 ` Shreeya Patel
2022-05-24 15:47 ` Rob Herring
2022-05-26 7:33 ` Shreeya Patel
2022-05-11 9:40 ` [PATCH v4 2/3] dt-bindings: Document ltrf216a light sensor bindings Shreeya Patel
2022-05-16 17:04 ` Rob Herring
2022-05-11 9:40 ` [PATCH v4 3/3] iio: light: Add support for ltrf216a sensor Shreeya Patel
2022-05-11 12:04 ` Andy Shevchenko
2022-05-12 23:40 ` Dmitry Osipenko
2022-05-14 16:17 ` Jonathan Cameron [this message]
2022-05-12 23:41 ` Dmitry Osipenko
2022-05-12 23:54 ` Dmitry Osipenko
2022-05-13 13:40 ` Shreeya Patel
2022-05-13 14:38 ` Shreeya Patel
2022-05-13 17:59 ` Dmitry Osipenko
2022-05-13 0:05 ` Dmitry Osipenko
2022-05-13 0:12 ` Dmitry Osipenko
2022-05-13 0:30 ` Dmitry Osipenko
2022-05-17 10:54 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514171738.062b127d@jic23-huawei \
--to=jic23@kernel.org \
--cc=Zhigang.Shi@liteon.com \
--cc=alvaro.soliverez@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).