* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
@ 2022-05-11 2:03 ` Peng Fan (OSS)
2022-05-12 14:19 ` Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Peng Fan (OSS) @ 2022-05-11 2:03 UTC (permalink / raw)
To: Laurent Pinchart, Shawn Guo, linux-arm-kernel, devicetree
Cc: Lucas Stach, Krzysztof Kozlowski, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, Paul Elder, Marek Vasut,
Rob Herring
On 2022/5/11 4:05, Laurent Pinchart wrote:
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> Shawn, this fixes an issue in linux-next, could you please apply the
> patch to your imx/bindings branch for v5.19 ?
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> index 21d3ee486295..b246d8386ba4 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> @@ -88,7 +88,7 @@ examples:
> <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>,
> <&mipi_phy2_pd>;
> power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi",
> - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2";
> + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2";
> clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
2022-05-11 2:03 ` Peng Fan (OSS)
@ 2022-05-12 14:19 ` Krzysztof Kozlowski
2022-05-16 7:31 ` paul.elder
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-12 14:19 UTC (permalink / raw)
To: Laurent Pinchart, Shawn Guo, linux-arm-kernel, devicetree
Cc: Lucas Stach, Krzysztof Kozlowski, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, Paul Elder, Marek Vasut,
Rob Herring
On 10/05/2022 22:05, Laurent Pinchart wrote:
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
2022-05-11 2:03 ` Peng Fan (OSS)
2022-05-12 14:19 ` Krzysztof Kozlowski
@ 2022-05-16 7:31 ` paul.elder
2022-05-16 15:11 ` Rob Herring
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: paul.elder @ 2022-05-16 7:31 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Shawn Guo, linux-arm-kernel, devicetree, Lucas Stach,
Krzysztof Kozlowski, Fabio Estevam, Pengutronix Kernel Team,
NXP Linux Team, Marek Vasut, Rob Herring
Hi Laurent,
On Tue, May 10, 2022 at 11:05:43PM +0300, Laurent Pinchart wrote:
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> Shawn, this fixes an issue in linux-next, could you please apply the
> patch to your imx/bindings branch for v5.19 ?
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> index 21d3ee486295..b246d8386ba4 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> @@ -88,7 +88,7 @@ examples:
> <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>,
> <&mipi_phy2_pd>;
> power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi",
> - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2";
> + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2";
> clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
` (2 preceding siblings ...)
2022-05-16 7:31 ` paul.elder
@ 2022-05-16 15:11 ` Rob Herring
2022-05-23 16:11 ` Rob Herring
2022-05-31 13:56 ` Rob Herring
5 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-16 15:11 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lucas Stach, Fabio Estevam, Pengutronix Kernel Team, Paul Elder,
Marek Vasut, Rob Herring, NXP Linux Team, Krzysztof Kozlowski,
Shawn Guo, devicetree, linux-arm-kernel
On Tue, 10 May 2022 23:05:43 +0300, Laurent Pinchart wrote:
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Shawn, this fixes an issue in linux-next, could you please apply the
> patch to your imx/bindings branch for v5.19 ?
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
` (3 preceding siblings ...)
2022-05-16 15:11 ` Rob Herring
@ 2022-05-23 16:11 ` Rob Herring
2022-05-31 13:56 ` Rob Herring
5 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-23 16:11 UTC (permalink / raw)
To: Laurent Pinchart, Shawn Guo
Cc: linux-arm-kernel, devicetree, Lucas Stach, Krzysztof Kozlowski,
Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team,
Paul Elder, Marek Vasut
On Tue, May 10, 2022 at 3:05 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Shawn, this fixes an issue in linux-next, could you please apply the
> patch to your imx/bindings branch for v5.19 ?
Ping! Still failing in linux-next.
Rob
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> index 21d3ee486295..b246d8386ba4 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> @@ -88,7 +88,7 @@ examples:
> <&mediamix_pd>, <&ispdwp_pd>, <&ispdwp_pd>,
> <&mipi_phy2_pd>;
> power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi",
> - "mipi-csi2", "lcdif2", "isp1", "dwe", "mipi-dsi2";
> + "mipi-csi2", "lcdif2", "isp", "dwe", "mipi-dsi2";
> clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
> <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-10 20:05 [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example Laurent Pinchart
` (4 preceding siblings ...)
2022-05-23 16:11 ` Rob Herring
@ 2022-05-31 13:56 ` Rob Herring
2022-05-31 21:02 ` Laurent Pinchart
5 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-05-31 13:56 UTC (permalink / raw)
To: Laurent Pinchart, Shawn Guo
Cc: Lucas Stach, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, Marek Vasut, Krzysztof Kozlowski, Paul Elder,
devicetree, linux-arm-kernel
On Tue, 10 May 2022 23:05:43 +0300, Laurent Pinchart wrote:
> The DT example incorrectly names the ISP power domain "isp1" instead of
> "isp". This causes a validation failure:
>
> Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
>
> Fix it.
>
> Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Shawn, this fixes an issue in linux-next, could you please apply the
> patch to your imx/bindings branch for v5.19 ?
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Now failing in Linus' tree and linux-next and no response, so I've
applied.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: soc: imx8mp-media-blk-ctrl: Fix DT example
2022-05-31 13:56 ` Rob Herring
@ 2022-05-31 21:02 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2022-05-31 21:02 UTC (permalink / raw)
To: Rob Herring
Cc: Shawn Guo, Lucas Stach, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, Marek Vasut, Krzysztof Kozlowski, Paul Elder,
devicetree, linux-arm-kernel
On Tue, May 31, 2022 at 08:56:39AM -0500, Rob Herring wrote:
> On Tue, 10 May 2022 23:05:43 +0300, Laurent Pinchart wrote:
> > The DT example incorrectly names the ISP power domain "isp1" instead of
> > "isp". This causes a validation failure:
> >
> > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.example.dtb: blk-ctl@32ec0000: power-domain-names:7: 'isp' was expected
> > From schema: Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> >
> > Fix it.
> >
> > Fixes: 584d6dd668e2 ("dt-bindings: soc: Add i.MX8MP media block control DT bindings")
> > Reported-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Shawn, this fixes an issue in linux-next, could you please apply the
> > patch to your imx/bindings branch for v5.19 ?
> > ---
> > .../devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Now failing in Linus' tree and linux-next and no response, so I've
> applied.
Thanks Rob.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread