From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58238C433F5 for ; Mon, 16 May 2022 16:34:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343841AbiEPQeA (ORCPT ); Mon, 16 May 2022 12:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343774AbiEPQd5 (ORCPT ); Mon, 16 May 2022 12:33:57 -0400 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E783B3F0; Mon, 16 May 2022 09:33:27 -0700 (PDT) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-f189b07f57so7325463fac.1; Mon, 16 May 2022 09:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CiuDSc5jE/tQy9qIvLJu2MZL0HMNt8pDPacw0cghyhk=; b=2/1iP//mSuINH/jJ//thfVZ6C863CPO9zN/iilpFucZNfI7xINcREvrvgDTNElWnC5 DGQ1U1vFu94sT+om4OAH8DafK2cz6jMbE8wNcwJ5YHtTbhS2fTXXJobcbit6nYGVF5G8 mjzcPrsUXvQdBNQABHEBOkYqrIdt5G0bktSmF8rwCZOlW9dqqEbnxE9kbqan+CwKnH45 VxX2c1DgRxugaR08NP9qsqsoOgJZco512TpR/Xr+VJiJnEU0iNnowgah4huOLgfoe2mK gQTLl3fg5yvGqEgI/HVgVxQ9ANrIN9JgcdIJmMvVkakQ99ybAWFqBRwGGs/2c1IuuC5W PhMA== X-Gm-Message-State: AOAM533koe6sT7LeXcPyYaoK4UwIOlrasNlBzwO16bK8SbTp5FEz7xfG TCq3ExJLCcWyCz3HFrLUhA== X-Google-Smtp-Source: ABdhPJycQNzePEJAzWR0E4hHkTqbdk/jDS1QEhfnLSWiGpLOPMe8c1wY+jAIc2jwGk3JGr3sEYpwMg== X-Received: by 2002:a05:6870:a1a0:b0:d9:b198:4cfa with SMTP id a32-20020a056870a1a000b000d9b1984cfamr10022635oaf.159.1652718806864; Mon, 16 May 2022 09:33:26 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d8-20020a056870e24800b000eb0e40b4b8sm5829199oac.48.2022.05.16.09.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 09:33:26 -0700 (PDT) Received: (nullmailer pid 2801600 invoked by uid 1000); Mon, 16 May 2022 16:33:25 -0000 Date: Mon, 16 May 2022 11:33:25 -0500 From: Rob Herring To: cyndis@kapsi.fi Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, krzysztof.kozlowski+dt@linaro.org, digetx@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Mikko Perttunen Subject: Re: [PATCH v1 01/13] dt-bindings: Add bindings for Tegra234 Host1x and VIC Message-ID: <20220516163325.GA2793304-robh@kernel.org> References: <20220516100213.1536571-1-cyndis@kapsi.fi> <20220516100213.1536571-2-cyndis@kapsi.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220516100213.1536571-2-cyndis@kapsi.fi> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 16, 2022 at 01:02:01PM +0300, cyndis@kapsi.fi wrote: > From: Mikko Perttunen > > Update VIC and Host1x bindings for changes in Tegra234. > > Namely, > - New compatible strings > - Sharded syncpoint interrupts > - Optional reset. > > Signed-off-by: Mikko Perttunen > --- > .../display/tegra/nvidia,tegra124-vic.yaml | 1 + > .../display/tegra/nvidia,tegra20-host1x.yaml | 108 +++++++++++++++--- > 2 files changed, 95 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-vic.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-vic.yaml > index 37bb5ddc1963..7200095ef19e 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-vic.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-vic.yaml > @@ -21,6 +21,7 @@ properties: > - nvidia,tegra210-vic > - nvidia,tegra186-vic > - nvidia,tegra194-vic > + - nvidia,tegra234-vic > > - items: > - const: nvidia,tegra132-vic > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml > index 0adeb03b9e3a..83c58b7dae98 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml > @@ -24,6 +24,7 @@ properties: > - nvidia,tegra210-host1x > - nvidia,tegra186-host1x > - nvidia,tegra194-host1x > + - nvidia,tegra234-host1x > > - items: > - const: nvidia,tegra132-host1x > @@ -31,23 +32,19 @@ properties: > > reg: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > > reg-names: > minItems: 1 > - maxItems: 2 > + maxItems: 3 > > interrupts: > - items: > - - description: host1x syncpoint interrupt > - - description: host1x general interrupt > minItems: 1 > + maxItems: 9 > > interrupt-names: > - items: > - - const: syncpt > - - const: host1x > minItems: 1 > + maxItems: 9 > > '#address-cells': > description: The number of cells used to represent physical base addresses > @@ -110,13 +107,32 @@ required: > - reg > - clocks > - clock-names > - - resets > - - reset-names Shouldn't these still be required on some platforms? > > additionalProperties: > type: object > > allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nvidia,tegra20-host1x > + - nvidia,tegra30-host1x > + - nvidia,tegra114-host1x > + - nvidia,tegra124-host1x > + - nvidia,tegra210-host1x > + then: > + properties: > + interrupts: > + items: > + - description: host1x syncpoint interrupt > + - description: host1x general interrupt > + > + interrupt-names: > + items: > + - const: syncpt > + - const: host1x > - if: > properties: > compatible: > @@ -133,10 +149,10 @@ allOf: > > reg: > items: > - - description: physical base address and length of the register > - region assigned to the VM > - description: physical base address and length of the register > region used by the hypervisor > + - description: physical base address and length of the register > + region assigned to the VM You can't just change the order at least without a good explanation why in the commit message. It's an ABI. > > resets: > maxItems: 1 > @@ -144,6 +160,70 @@ allOf: > reset-names: > maxItems: 1 > > + interrupts: > + items: > + - description: host1x syncpoint interrupt > + - description: host1x general interrupt > + > + interrupt-names: > + items: > + - const: syncpt > + - const: host1x > + > + iommu-map: > + description: Specification of stream IDs available for memory context device > + use. Should be a mapping of IDs 0..n to IOMMU entries corresponding to > + usable stream IDs. > + > + required: > + - reg-names > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nvidia,tegra234-host1x > + then: > + properties: > + reg-names: > + items: > + - const: common > + - const: hypervisor > + - const: vm > + > + reg: > + items: > + - description: physical base address and length of the register > + region used by host1x server > + - description: physical base address and length of the register > + region used by the hypervisor > + - description: physical base address and length of the register > + region assigned to the VM I guess this is just copied, but 'physical base address and length of the ' is redundant. That's every 'reg'. > + > + interrupts: > + items: > + - description: host1x syncpoint interrupt 0 > + - description: host1x syncpoint interrupt 1 > + - description: host1x syncpoint interrupt 2 > + - description: host1x syncpoint interrupt 3 > + - description: host1x syncpoint interrupt 4 > + - description: host1x syncpoint interrupt 5 > + - description: host1x syncpoint interrupt 6 > + - description: host1x syncpoint interrupt 7 > + - description: host1x general interrupt > + > + interrupt-names: > + items: > + - const: syncpt0 > + - const: syncpt1 > + - const: syncpt2 > + - const: syncpt3 > + - const: syncpt4 > + - const: syncpt5 > + - const: syncpt6 > + - const: syncpt7 > + - const: host1x > + > iommu-map: > description: Specification of stream IDs available for memory context device > use. Should be a mapping of IDs 0..n to IOMMU entries corresponding to > @@ -160,8 +240,8 @@ examples: > host1x@50000000 { > compatible = "nvidia,tegra20-host1x"; > reg = <0x50000000 0x00024000>; > - interrupts = <0 65 0x04 /* mpcore syncpt */ > - 0 67 0x04>; /* mpcore general */ > + interrupts = <0 65 0x04>, /* mpcore syncpt */ > + <0 67 0x04>; /* mpcore general */ > interrupt-names = "syncpt", "host1x"; > clocks = <&tegra_car TEGRA20_CLK_HOST1X>; > clock-names = "host1x"; > -- > 2.36.1 > >