From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Sandy Huang" <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Peter Geis" <pgwipeout@gmail.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2
Date: Mon, 16 May 2022 19:08:40 +0200 [thread overview]
Message-ID: <20220516170840.GO25578@pengutronix.de> (raw)
In-Reply-To: <20220516151226.GA2653888-robh@kernel.org>
Heiko,
On Mon, May 16, 2022 at 10:12:26AM -0500, Rob Herring wrote:
> On Wed, 11 May 2022 10:21:07 +0200, Sascha Hauer wrote:
> > The VOP2 driver relies on reg-names properties, but these are not
> > documented. Add the missing documentation, make reg-names mandatory
> > and increase minItems to 2 as always both register spaces are needed.
Could you drop the minItems part while applying? That is no longer
correct.
Sascha
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >
> > Notes:
> > Changes since v1:
> > - Drop minItems
> > - Add reg-names properties to example
> >
> > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-05-16 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:21 [PATCH v2 0/3] RK356x VOP2: Change register space names Sascha Hauer
2022-05-11 8:21 ` [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Sascha Hauer
2022-05-13 22:26 ` Heiko Stuebner
2022-05-17 9:02 ` Krzysztof Kozlowski
2022-05-17 9:10 ` Heiko Stübner
2022-05-16 15:12 ` Rob Herring
2022-05-16 17:08 ` Sascha Hauer [this message]
2022-05-11 8:21 ` [PATCH v2 2/3] drm: rockchip: Change register space names Sascha Hauer
2022-05-11 8:21 ` [PATCH v2 3/3] arm64: dts: rockchip: rk356x: Change VOP2 " Sascha Hauer
2022-05-16 22:26 ` (subset) [PATCH v2 0/3] RK356x VOP2: Change " Heiko Stuebner
2022-05-17 18:22 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516170840.GO25578@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).