From: Vladimir Oltean <olteanv@gmail.com>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5 08/13] net: dsa: rzn1-a5psw: add statistics support
Date: Thu, 19 May 2022 21:24:34 +0300 [thread overview]
Message-ID: <20220519182434.ncjyoelgndvoev33@skbuf> (raw)
In-Reply-To: <20220519153107.696864-9-clement.leger@bootlin.com>
On Thu, May 19, 2022 at 05:31:02PM +0200, Clément Léger wrote:
> diff --git a/drivers/net/dsa/rzn1_a5psw.h b/drivers/net/dsa/rzn1_a5psw.h
> index 306cab55db24..649165d37fde 100644
> --- a/drivers/net/dsa/rzn1_a5psw.h
> +++ b/drivers/net/dsa/rzn1_a5psw.h
> @@ -146,7 +146,50 @@
>
> #define A5PSW_STATS_HIWORD 0x900
>
> -#define A5PSW_DUMMY_WORKAROUND 0x5000
> +/* Stats */
> +#define A5PSW_aFramesTransmittedOK 0x868
> +#define A5PSW_aFramesReceivedOK 0x86C
> +#define A5PSW_aFrameCheckSequenceErrors 0x870
> +#define A5PSW_aAlignmentErrors 0x874
> +#define A5PSW_aOctetsTransmittedOK 0x878
> +#define A5PSW_aOctetsReceivedOK 0x87C
> +#define A5PSW_aTxPAUSEMACCtrlFrames 0x880
> +#define A5PSW_aRxPAUSEMACCtrlFrames 0x884
> + /* If */
It would probably be good to keep the same alignment for all comments here.
> +#define A5PSW_ifInErrors 0x888
> +#define A5PSW_ifOutErrors 0x88C
> +#define A5PSW_ifInUcastPkts 0x890
> +#define A5PSW_ifInMulticastPkts 0x894
> +#define A5PSW_ifInBroadcastPkts 0x898
> +#define A5PSW_ifOutDiscards 0x89C
> +#define A5PSW_ifOutUcastPkts 0x8A0
> +#define A5PSW_ifOutMulticastPkts 0x8A4
> +#define A5PSW_ifOutBroadcastPkts 0x8A8
> + /* Ether */
> +#define A5PSW_etherStatsDropEvents 0x8AC
> +#define A5PSW_etherStatsOctets 0x8B0
> +#define A5PSW_etherStatsPkts 0x8B4
> +#define A5PSW_etherStatsUndersizePkts 0x8B8
> +#define A5PSW_etherStatsOversizePkts 0x8BC
> +#define A5PSW_etherStatsPkts64Octets 0x8C0
> +#define A5PSW_etherStatsPkts65to127Octets 0x8C4
> +#define A5PSW_etherStatsPkts128to255Octets 0x8C8
> +#define A5PSW_etherStatsPkts256to511Octets 0x8CC
> +#define A5PSW_etherStatsPkts512to1023Octets 0x8D0
> +#define A5PSW_etherStatsPkts1024to1518Octets 0x8D4
> +#define A5PSW_etherStatsPkts1519toXOctets 0x8D8
> +#define A5PSW_etherStatsJabbers 0x8DC
> +#define A5PSW_etherStatsFragments 0x8E0
> +
> +#define A5PSW_VLANReceived 0x8E8
> +#define A5PSW_VLANTransmitted 0x8EC
> +
> +#define A5PSW_aDeferred 0x910
> +#define A5PSW_aMultipleCollisions 0x914
> +#define A5PSW_aSingleCollisions 0x918
> +#define A5PSW_aLateCollisions 0x91C
> +#define A5PSW_aExcessiveCollisions 0x920
> +#define A5PSW_aCarrierSenseErrors 0x924
next prev parent reply other threads:[~2022-05-19 18:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 15:30 [PATCH net-next v5 00/13] add support for Renesas RZ/N1 ethernet subsystem devices Clément Léger
2022-05-19 15:30 ` [PATCH net-next v5 01/13] net: dsa: allow port_bridge_join() to override extack message Clément Léger
2022-05-19 17:53 ` Vladimir Oltean
2022-05-19 15:30 ` [PATCH net-next v5 02/13] net: dsa: add support for ethtool get_rmon_stats() Clément Léger
2022-05-19 15:30 ` [PATCH net-next v5 03/13] net: dsa: add Renesas RZ/N1 switch tag driver Clément Léger
2022-05-19 15:30 ` [PATCH net-next v5 04/13] dt-bindings: net: pcs: add bindings for Renesas RZ/N1 MII converter Clément Léger
2022-05-20 7:09 ` Geert Uytterhoeven
2022-05-19 15:30 ` [PATCH net-next v5 05/13] net: pcs: add Renesas MII converter driver Clément Léger
2022-05-19 16:25 ` Russell King (Oracle)
2022-05-20 7:52 ` Clément Léger
2022-05-20 8:49 ` Vladimir Oltean
2022-05-20 15:22 ` Clément Léger
2022-05-20 15:44 ` Vladimir Oltean
2022-05-20 15:49 ` Clément Léger
2022-05-20 15:58 ` Vladimir Oltean
2022-05-20 16:22 ` Clément Léger
2022-05-19 15:31 ` [PATCH net-next v5 06/13] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch Clément Léger
2022-05-20 7:13 ` Geert Uytterhoeven
2022-05-20 7:57 ` Clément Léger
2022-05-20 8:01 ` Geert Uytterhoeven
2022-05-20 8:16 ` Clément Léger
2022-05-24 2:34 ` Rob Herring
2022-05-19 15:31 ` [PATCH net-next v5 07/13] net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver Clément Léger
2022-05-19 18:08 ` Vladimir Oltean
2022-05-20 7:58 ` Clément Léger
2022-05-19 15:31 ` [PATCH net-next v5 08/13] net: dsa: rzn1-a5psw: add statistics support Clément Léger
2022-05-19 18:24 ` Vladimir Oltean [this message]
2022-05-19 15:31 ` [PATCH net-next v5 09/13] net: dsa: rzn1-a5psw: add FDB support Clément Léger
2022-05-19 18:12 ` Vladimir Oltean
2022-05-19 15:31 ` [PATCH net-next v5 10/13] ARM: dts: r9a06g032: describe MII converter Clément Léger
2022-05-19 15:31 ` [PATCH net-next v5 11/13] ARM: dts: r9a06g032: describe GMAC2 Clément Léger
2022-05-20 7:18 ` Geert Uytterhoeven
2022-05-20 8:13 ` Clément Léger
2022-05-20 8:25 ` Geert Uytterhoeven
2022-05-20 8:31 ` Clément Léger
2022-05-20 8:48 ` Geert Uytterhoeven
2022-05-19 15:31 ` [PATCH net-next v5 12/13] ARM: dts: r9a06g032: describe switch Clément Léger
2022-05-19 18:28 ` Vladimir Oltean
2022-05-20 8:18 ` Clément Léger
2022-05-19 15:31 ` [PATCH net-next v5 13/13] MAINTAINERS: add Renesas RZ/N1 switch related driver entry Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519182434.ncjyoelgndvoev33@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=jimmy.lalande@se.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).