devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc: lars@metafoo.de, mchehab+huawei@kernel.org,
	ardeleanalex@gmail.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	mike.looijmans@topic.nl, devicetree@vger.kernel.org,
	thomas.haemmerle@leica-geosystems.com
Subject: Re: [PATCH V3 0/6] iio: accel: bmi088: support BMI085 BMI090L
Date: Sun, 22 May 2022 12:37:19 +0100	[thread overview]
Message-ID: <20220522123719.3e34bb6e@jic23-huawei> (raw)
In-Reply-To: <20220518150425.927988-1-Qing-wu.Li@leica-geosystems.com.cn>

On Wed, 18 May 2022 15:04:19 +0000
LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> wrote:

> Modified the units after application of scale from 100*m/s^2 to m/s^2,
> since the units in the ABI documents are m/s^2.
> Add supports for the BMI085 accelerometer.
> Add supports for the BMI090L accelerometer.
> Make it possible to config scales.
> 
> Change in V3: 
> 
> Use FIELD_GET for checking register range. Reorder the chip info and 
> dt-bindings alphabetical. Add of_id_table. Modify the logic of loading
> sensor chip info. If the device was found in the table but the device 
> tree binding is different, the driver will carry on with the detected
> chip with a warning. If no matching device was found, the driver load
> the binding chip.

All looks good to me. Unfortunately we've missed the 5.19 merge window
now as it will probably open shortly.  As such we have lots of time so
I'll leave this on list for a little longer for others to take a look at.
Thanks,

Jonathan

> 
> 
> LI Qingwu (6):
>   iio: accel: bmi088: Modified the scale calculate
>   iio: accel: bmi088: Make it possible to config scales
>   iio: accel: bmi088: modified the device name
>   iio: accel: bmi088: Add support for bmi085 accel
>   iio: accel: bmi088: Add support for bmi090l accel
>   dt-bindings: iio: accel: Add bmi085 and bmi090l bindings
> 
>  .../bindings/iio/accel/bosch,bmi088.yaml      |  2 +
>  drivers/iio/accel/bmi088-accel-core.c         | 96 +++++++++++++++----
>  drivers/iio/accel/bmi088-accel-spi.c          | 17 +++-
>  drivers/iio/accel/bmi088-accel.h              |  9 +-
>  4 files changed, 100 insertions(+), 24 deletions(-)
> 


      parent reply	other threads:[~2022-05-22 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 15:04 [PATCH V3 0/6] iio: accel: bmi088: support BMI085 BMI090L LI Qingwu
2022-05-18 15:04 ` [PATCH V3 1/6] iio: accel: bmi088: Modified the scale calculate LI Qingwu
2022-05-18 15:04 ` [PATCH V3 2/6] iio: accel: bmi088: Make it possible to config scales LI Qingwu
2022-05-18 15:04 ` [PATCH V3 3/6] iio: accel: bmi088: modified the device name LI Qingwu
2022-05-18 15:04 ` [PATCH V3 4/6] iio: accel: bmi088: Add support for bmi085 accel LI Qingwu
2022-05-18 15:04 ` [PATCH V3 5/6] iio: accel: bmi088: Add support for bmi090l accel LI Qingwu
2022-05-18 15:04 ` [PATCH V3 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l bindings LI Qingwu
2022-05-22 11:37 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220522123719.3e34bb6e@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Qing-wu.Li@leica-geosystems.com.cn \
    --cc=ardeleanalex@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mike.looijmans@topic.nl \
    --cc=robh+dt@kernel.org \
    --cc=thomas.haemmerle@leica-geosystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).