From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sboyd@kernel.org, chun-jie.chen@mediatek.com,
rex-bc.chen@mediatek.com, wenst@chromium.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property
Date: Mon, 23 May 2022 09:08:15 -0500 [thread overview]
Message-ID: <20220523140815.GA1500210-robh@kernel.org> (raw)
In-Reply-To: <288690ac-b23b-92f8-64b4-d994f249f21c@linaro.org>
On Sat, May 21, 2022 at 04:05:01PM +0200, Krzysztof Kozlowski wrote:
> On 21/05/2022 00:19, Rob Herring wrote:
> > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote:
> >> This is a clock-controller binding, so it needs #clock-cells, or
> >> it would be of no use: add that to the list of required properties.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
> >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 +
> >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 +
> >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> >> 6 files changed, 6 insertions(+)
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> >
> > Wasn't there some discussion about moving these to bindings/clocks/?
> > Maybe that was another one, it's all a blur...
>
> Yes, there was such idea although I am not sure if this is worth by
> itself - messes up with the git history.
There shouldn't be too much history since converting to schema. For just
a move git is smart enough to see across moves.
Rob
prev parent reply other threads:[~2022-05-23 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 9:36 [PATCH v2 0/2] dt-bindings: arm: MediaTek: Fix clock bindings AngeloGioacchino Del Regno
2022-05-18 9:36 ` [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting AngeloGioacchino Del Regno
2022-05-20 22:16 ` Rob Herring
2022-05-18 9:36 ` [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property AngeloGioacchino Del Regno
2022-05-18 11:46 ` Krzysztof Kozlowski
2022-05-18 11:50 ` AngeloGioacchino Del Regno
2022-05-20 22:19 ` Rob Herring
2022-05-21 14:05 ` Krzysztof Kozlowski
2022-05-23 14:08 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523140815.GA1500210-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).