From: Markuss Broks <markuss.broks@gmail.com>
To: linux-kernel@vger.kernel.org, jic23@kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Markuss Broks <markuss.broks@gmail.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Song Qiang <songqiang1304521@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH 2/5] proximity: vl53l0x: Prefer pre-initialized interrupt flags
Date: Mon, 23 May 2022 20:53:41 +0300 [thread overview]
Message-ID: <20220523175344.5845-3-markuss.broks@gmail.com> (raw)
In-Reply-To: <20220523175344.5845-1-markuss.broks@gmail.com>
On some boards interrupt type might be different than falling edge,
like hardcoded in driver. Leave interrupt flags as they were pre-configured
from the device-tree. If they're not provided, default to falling edge
interrupts.
Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
drivers/iio/proximity/vl53l0x-i2c.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
index 661a79ea200d..12a3e2eff464 100644
--- a/drivers/iio/proximity/vl53l0x-i2c.c
+++ b/drivers/iio/proximity/vl53l0x-i2c.c
@@ -16,6 +16,7 @@
#include <linux/delay.h>
#include <linux/i2c.h>
+#include <linux/irq.h>
#include <linux/interrupt.h>
#include <linux/module.h>
@@ -57,11 +58,15 @@ static irqreturn_t vl53l0x_handle_irq(int irq, void *priv)
static int vl53l0x_configure_irq(struct i2c_client *client,
struct iio_dev *indio_dev)
{
+ int irq_flags = irq_get_trigger_type(client->irq);
struct vl53l0x_data *data = iio_priv(indio_dev);
int ret;
+ if (!irq_flags)
+ irq_flags = IRQF_TRIGGER_FALLING;
+
ret = devm_request_irq(&client->dev, client->irq, vl53l0x_handle_irq,
- IRQF_TRIGGER_FALLING, indio_dev->name, indio_dev);
+ irq_flags, indio_dev->name, indio_dev);
if (ret) {
dev_err(&client->dev, "devm_request_irq error: %d\n", ret);
return ret;
--
2.36.1
next prev parent reply other threads:[~2022-05-23 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 17:53 [PATCH v5 0/5] Add support for ToF sensor on Yoshino platform Markuss Broks
2022-05-23 17:53 ` [PATCH 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties Markuss Broks
2022-05-23 17:53 ` Markuss Broks [this message]
2022-05-23 17:53 ` [PATCH 3/5] proximity: vl53l0x: Handle the VDD regulator Markuss Broks
2022-06-08 10:18 ` Luca Weiss
2022-06-12 8:53 ` Jonathan Cameron
2022-06-12 9:28 ` Luca Weiss
2022-06-14 10:48 ` Jonathan Cameron
2022-06-14 10:58 ` Jonathan Cameron
2022-05-23 17:53 ` [PATCH 4/5] proximity: vl53l0x: Handle the reset GPIO Markuss Broks
2022-05-23 17:53 ` [PATCH 5/5] arm64: dts: qcom: msm8998-xperia: Introduce ToF sensor support Markuss Broks
2022-07-03 3:56 ` (subset) " Bjorn Andersson
2022-06-03 15:23 ` [PATCH v5 0/5] Add support for ToF sensor on Yoshino platform Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523175344.5845-3-markuss.broks@gmail.com \
--to=markuss.broks@gmail.com \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=songqiang1304521@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).