From: Rob Herring <robh@kernel.org>
To: Taniya Das <quic_tdas@quicinc.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette " <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: Add resets for LPASS audio clock controller for SC7280
Date: Mon, 23 May 2022 21:06:50 -0500 [thread overview]
Message-ID: <20220524020650.GA2605976-robh@kernel.org> (raw)
In-Reply-To: <20220523092314.14252-2-quic_tdas@quicinc.com>
On Mon, May 23, 2022 at 02:53:12PM +0530, Taniya Das wrote:
> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
> for SC7280. Update reg property min/max items in YAML schema.
>
> Fixes: 57405b795504 ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280").
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> .../clock/qcom,sc7280-lpasscorecc.yaml | 20 ++++++++++++++++---
> .../clock/qcom,lpassaudiocc-sc7280.h | 5 +++++
> 2 files changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
> index bad9135489de..f066e8c57bbf 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml
> @@ -22,6 +22,8 @@ properties:
>
> clock-names: true
>
> + reg: true
> +
> compatible:
> enum:
> - qcom,sc7280-lpassaoncc
> @@ -38,8 +40,8 @@ properties:
> '#power-domain-cells':
> const: 1
>
> - reg:
> - maxItems: 1
> + '#reset-cells':
> + const: 1
>
> required:
> - compatible
> @@ -69,6 +71,12 @@ allOf:
> items:
> - const: bi_tcxo
> - const: lpass_aon_cc_main_rcg_clk_src
> +
> + reg:
> + maxItems: 2
Don't need maxItems. 2 is implied from 'items' length.
> + items:
> + - description: lpass core cc register
> + - description: lpass audio csr register
> - if:
> properties:
> compatible:
> @@ -90,6 +98,8 @@ allOf:
> - const: bi_tcxo_ao
> - const: iface
>
> + reg:
> + maxItems: 1
> - if:
> properties:
> compatible:
> @@ -108,6 +118,8 @@ allOf:
> items:
> - const: bi_tcxo
>
> + reg:
> + maxItems: 1
> examples:
> - |
> #include <dt-bindings/clock/qcom,rpmh.h>
> @@ -116,13 +128,15 @@ examples:
> #include <dt-bindings/clock/qcom,lpasscorecc-sc7280.h>
> lpass_audiocc: clock-controller@3300000 {
> compatible = "qcom,sc7280-lpassaudiocc";
> - reg = <0x3300000 0x30000>;
> + reg = <0x3300000 0x30000>,
> + <0x32a9000 0x1000>;
> clocks = <&rpmhcc RPMH_CXO_CLK>,
> <&lpass_aon LPASS_AON_CC_MAIN_RCG_CLK_SRC>;
> clock-names = "bi_tcxo", "lpass_aon_cc_main_rcg_clk_src";
> power-domains = <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
> #clock-cells = <1>;
> #power-domain-cells = <1>;
> + #reset-cells = <1>;
> };
>
> - |
> diff --git a/include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h b/include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h
> index 20ef2ea673f3..22dcd47d4513 100644
> --- a/include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h
> +++ b/include/dt-bindings/clock/qcom,lpassaudiocc-sc7280.h
> @@ -24,6 +24,11 @@
> #define LPASS_AUDIO_CC_RX_MCLK_CLK 14
> #define LPASS_AUDIO_CC_RX_MCLK_CLK_SRC 15
>
> +/* LPASS AUDIO CC CSR */
> +#define LPASS_AUDIO_SWR_RX_CGCR 0
> +#define LPASS_AUDIO_SWR_TX_CGCR 1
> +#define LPASS_AUDIO_SWR_WSA_CGCR 2
> +
> /* LPASS_AON_CC clocks */
> #define LPASS_AON_CC_PLL 0
> #define LPASS_AON_CC_PLL_OUT_EVEN 1
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2022-05-24 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 9:23 [PATCH v2 0/3] Add support for audio clock gating resets for SC7280 Taniya Das
2022-05-23 9:23 ` [PATCH v2 1/3] dt-bindings: clock: Add resets for LPASS audio clock controller " Taniya Das
2022-05-24 2:06 ` Rob Herring [this message]
2022-05-23 9:23 ` [PATCH v2 2/3] dt-bindings: clock: Add support for external MCLKs for LPASS on SC7280 Taniya Das
2022-05-24 2:07 ` Rob Herring
2022-05-23 9:23 ` [PATCH v2 3/3] clk: qcom: lpass: Add support for resets & external mclk for SC7280 Taniya Das
2022-05-25 17:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524020650.GA2605976-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).